Dark theme variants and global runs select-all - #7154
Closed
CarsonBurke wants to merge 38 commits into
Closed
CarsonBurke wants to merge 38 commits into
CarsonBurke wants to merge 38 commits into
Conversation
Improve local TensorBoard run workflows
An empty bytestring written via _AsyncWriterThread was written to disk but never marked done because the worker tested truthiness, hanging every later flush() forever. Fixes #2
The guard used < where <= is required for a zero-based index, so a step holding exactly sample clips raised IndexError (HTTP 500). Fixes #3
The thread-local markdown.Markdown instance kept state such as reference definitions across convert() calls, so link targets from one document could leak into later unrelated documents. Fixes #4
get_all promised to silently ignore invalid entries but re-raised EISDIR/ENOENT: a planted subdirectory was a persistent local DoS, and a file removed by an exiting peer between listdir and open crashed the snapshot. Skip non-regular files (a FIFO would block open forever) and ignore ENOENT/EISDIR alongside EACCES. Fixes #5
The early return skipped listener removal, state reset, and highlight clearing when a drag ended outside any header, leaving page-wide dragover suppression and stale state behind. Only the orderColumns emit needs the guard. Fixes #6
getSavedScalarPins parsed blindly, so malformed JSON threw during the pin-restore effect and wrong-shape values crashed downstream. Mirror the safeParse siblings: return [] on parse failure or non-string arrays. Fixes #7
getPersistentFeatureFlags threw on malformed JSON, breaking
bootstrap flag resolution. Return {} on parse failure. Also wires
the orphaned feature_flag_test_lib into the karma suite so these
specs actually run.
Fixes #8
into_tensor kept all N buckets with min/max as outer edges, producing backwards (negative-width) outer buckets, while _migrate_histogram_value in data_compat.py drops empty buckets on both ends. Port the trimming so both backends serve identical histogram tensors. Fixes #9
Add Catppuccin, Tokyo Night, GitHub, VS Code, and Codex as dark theme variants alongside the default dark theme. The header theme menu gains a dark-theme section; the choice is stored as a darkThemeId feature flag, persisted in global settings and honored as a ?darkTheme= query param, and applied via body[data-tb-dark-theme] with per-variant Material themes plus variant-aware tb-theme prop mixins (including dark-only helpers for surfaces that previously read the baseline dark maps directly).
Covers the in-progress audit fixes on this branch. Notably, runs select-all now resolves the full filtered scope in paged mode via a new selectAllRuns action and effect instead of toggling only the loaded window (header toggle previously left every other page untouched). Verified with the webapp karma suite and a 150-run browser session.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two user-facing changes on top of the audit fixes:
Selectable darker themes (catppuccin, tokyo-night, github, vscode, codex)
darkThemeIdfeature flag, persisted in global settings and honored as?darkTheme=.body[data-tb-dark-theme], plus variant-aware tb-theme prop mixins (and dark-only helpers for surfaces that read the baseline dark maps directly).Runs select-all covers every page
selectAllRunsaction + effect resolves the full filtered scope with the same query/filters/sort as the catalog fetch, then toggles via the existingrunPageSelectionToggledreducer. Legacy non-paged path unchanged.Still to test before merging: large-scale perf of the full-scope select-all fetch, and review of the remaining audit WIP snapshotted in the second commit.