Repository navigation
chore(dev): Compose stack with PostgreSQL 17 and SeaweedFS, database roles and Makefile - #23
Conversation
🐕 Shuni ReviewNo new issues found. 🤖 Model: Review scope: Partial incremental re-review Reviewed new changes (2)
🐕 Review complete — View session on Shuni Portal 🐾 🤖 Model: |
|
| Topic | Details | ||||||
|---|---|---|---|---|---|---|---|
| Integration CI | Validate the Compose configuration and run integration builds and tests against the development services in CI, while documenting commands, fake-port expectations, and Docker safety rules.Modified files (2)
Latest Contributors(1)
| ||||||
| Development stack | Provision PostgreSQL and SeaweedFS locally with health checks, persistent storage, role and extension initialization, environment defaults, and safe Makefile lifecycle commands.Modified files (6)
Latest Contributors(1)
|
|
Job times (seconds) from this pull request's CI run (first run of the two new jobs; image pulls were cold on the RunsOn machine).
Docker was available on the RunsOn machine, both images pulled without rate limiting, and the database and file store became healthy. |
84f8fad to
881f4a8
Compare
…roles and Makefile
881f4a8 to
6e6cfd6
Compare
…: make rows are not pre-approved
Pull request was converted to draft
What changed
The development stack:
compose.yaml(PostgreSQL 17 and SeaweedFS, database roles and extensions created on an empty volume),.env.example, thedb/initscripts and a firstMakefile(db-up,down,db-down,down-volumes,test; the development token secret is generated per checkout, never a fixed default). CI gains two jobs:Compose config(validates the Compose file, hosted runner) andIntegration tests(RunsOn: starts the stack withmake db-up, builds, runs the integration project, always tears down; there are no integration tests yet, so it exits with success).AGENTS.mdlists the new commands, states the CI jobs and the fake-per-port rule as it is today, and the Docker safety rules now apply without condition.Rebased onto
main(the slice below it has merged); auto-merge is on.Why
Integration tests in later slices need a real database and file store; the stack and the job are reviewed on their own first.
How it was verified
In the generated tree, exactly what the jobs run:
docker compose -p grimoire config --quiet(with.envcopied from.env.example);make db-up(both services healthy in 5.5 s with the images already present);bun run build;bun run test:integration;make down-volumes(no containers or volumes left). Thenbun install --frozen-lockfile, lint, typecheck, build, unit, tool tests, licence, gitleaks, actionlint, zizmor: all exit 0.Visuals
Job times from this pull request's own CI run are in the first comment.
Not here yet
The integration tests themselves, the image and stack job, and the exit tests.
Checklist