Skip to content

chore: use mise for repository tooling - #13

Merged
omercnet merged 5 commits into
mainfrom
chore/use-mise
Nov 21, 2026
Merged

omercnet merged 5 commits into
mainfrom
chore/use-mise

Conversation

@omercnet

Copy link
Copy Markdown
Contributor

What changed

mise.toml is now the single source of tool versions: Node 26, gitleaks 8.30.1, actionlint 1.7.12, zizmor 1.30.1. mise.lock pins each download with its checksum (four platforms). The .nvmrc file is removed (mise.toml wins; package.json engines keeps the range). CI installs tools with jdx/mise-action (pinned by commit SHA, tag v5.2.9, the same version as tektum/procella) instead of actions/setup-node, hand-written curl downloads and the zizmor action. Renovate's mise manager keeps mise.toml and mise.lock current; the regex entries for the curl-installed versions are removed. CONTRIBUTING.md names mise install as the set-up step.

Unchanged: the fork guard, permissions, the CI Required gate, runner labels. Commands stay in npm scripts and the Makefile; no mise tasks (the organisation's repositories use mise for tools only).

Why

One place for versions, with checksums verified by the lock instead of hand-copied hashes.

How it was verified

mise install then npm ci --ignore-scripts, lint, typecheck, build, tests, npm run test:tools, gitleaks, actionlint, zizmor: all exit 0. A lock whose checksum is altered makes mise install fail (checked locally). The action's default cache key hashes mise.toml and mise.lock.

Visuals

Not applicable: tooling-only change; job times before and after are in the first comment.

Checklist

  • Tests added or updated, or not applicable
  • No secrets or credentials committed
  • Docs updated, or not applicable

@shuni-bot

shuni-bot Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

🐕 Shuni Review

No new issues found.

🤖 Model: claude-opus-5.5 · Effort: medium


Review scope: Partial incremental re-review

Reviewed new changes (2)
  • .github/workflows/ci.yml
  • mise.toml
Previously reviewed and unchanged: 4 files.

🐕 Review complete — View session on Shuni Portal 🐾

🤖 Model: claude-opus-5.5 · Effort: medium

@omercnet
omercnet enabled auto-merge (squash) November 21, 2026 10:25
@baz-reviewer

baz-reviewer Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

Review this PR on Baz

Baz Summary

Centralize Node and repository tool versions in mise.toml with checksum-pinned downloads in mise.lock, and document mise install for local setup. Update CI to install Node, gitleaks, actionlint, and zizmor through the pinned jdx/mise-action, while Renovate maintains the mise configuration.

Topics

TopicDetails
Toolchain management Centralize versioned development and security tools in mise.toml and mise.lock, remove .nvmrc, and configure Renovate to update the pinned tools.
Modified files (5)
  • .nvmrc
  • CONTRIBUTING.md
  • mise.lock
  • mise.toml
  • renovate.json
Latest Contributors(1)
UserCommitDate
omercnetchore: pin bun in mise...November 21, 2026
CI tool installation Replace manual binary downloads, actions/setup-node, and the zizmor action with checksum-verified tools installed through the pinned jdx/mise-action in CI.
Modified files (1)
  • .github/workflows/ci.yml
Latest Contributors(1)
UserCommitDate
omercnetdocs: say what bun is ...November 21, 2026


Merger  Activate to get a short verdict whether this PR is good to go or not

Skills  Activate Skill Maintainer to keep your skills up to date

Planner  This PR would have been improved with Baz Planner - Try it now

baz-app[bot]
baz-app Bot previously approved these changes Nov 21, 2026

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: 3 inline findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Comment thread mise.toml Resolved
Comment thread .github/workflows/ci.yml Resolved
Comment thread .github/workflows/ci.yml Resolved
@baz-app
baz-app Bot dismissed their stale review November 21, 2026 10:28

Baz withdrew its approval because this pull request is no longer ready to merge.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: 1 inline finding. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Comment thread mise.toml Resolved

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: 1 inline finding. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

Comment thread .github/workflows/ci.yml Resolved

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@shuni-bot shuni-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐕 Shuni review: no new findings. Every changed file in this pull request was reviewed.

The full review summary is in Shuni's sticky review comment on this pull request.

@omercnet
omercnet merged commit ab97329 into main Nov 21, 2026
11 checks passed
@omercnet
omercnet deleted the chore/use-mise branch November 21, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant