ty as yet another type checker - #5058
Conversation
Still heavily reduced ruleset, but over time, things should improve.
happz
added
the
code | type annotations
happz
added
the
test coverage
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request integrates the ty pre-commit hook, configures its rules in pyproject.toml, and updates the return type of execute in tmt/guest/__init__.py to be optional. Correct the typo call-top-callable to call-non-callable in the pyproject.toml configuration.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| invalid-yield = "ignore" | ||
| possibly-missing-submodule = "ignore" | ||
| invalid-generic-class = "ignore" | ||
| call-top-callable = "ignore" |
There was a problem hiding this comment.
Correct the typo call-top-callable to call-non-callable.
| call-top-callable = "ignore" | |
| call-non-callable = "ignore" |
LecrisUT
left a comment
LecrisUT
left a comment
There was a problem hiding this comment.
Should start type-checking the tests also at some point
2 participants
Still heavily reduced ruleset, but over time, things should improve.
Pull Request Checklist