Skip to content

Adding methods for building environment in the right order - #5057

Open
happz wants to merge 2 commits into
intrinsic-environmentfrom
environment-builder-with-ordering
Open

Adding methods for building environment in the right order#5057
happz wants to merge 2 commits into
intrinsic-environmentfrom
environment-builder-with-ordering

Conversation

@happz

@happz happz commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Pull Request Checklist

  • implement the feature
  • write the documentation

@happz happz added this to planning Jul 13, 2026
@happz happz added the area | environment Environment variables handling label Jul 13, 2026
@github-project-automation github-project-automation Bot moved this to backlog in planning Jul 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request centralizes and refactors environment building and refreshing logic across various tmt modules by introducing Environment.build_environment and refresh_intrinsics methods, and establishes a common StepContext base class for step contexts. Feedback recommends correcting the environment variable precedence order in _build_environment to prevent guest-level variables from overriding test-level ones, and returning a copy of the environment in refresh_intrinsics to avoid modifying the cached environment in place.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tmt/utils/environment.py
Comment thread tmt/utils/environment.py
@happz
happz force-pushed the environment-builder-with-ordering branch from 20f846a to 3b11a1f Compare July 13, 2026 07:33
@happz happz added the ci | full test Pull request is ready for the full test execution label Jul 13, 2026
@happz

happz commented Jul 13, 2026

Copy link
Copy Markdown
Contributor Author

/packit test

@happz happz moved this from backlog to review in planning Jul 13, 2026
@happz
happz marked this pull request as ready for review July 13, 2026 15:05
@happz happz mentioned this pull request Jul 21, 2026
8 tasks
@happz
happz force-pushed the environment-builder-with-ordering branch from 9bbbf42 to 76808fc Compare August 3, 2026 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area | environment Environment variables handling ci | full test Pull request is ready for the full test execution

Projects

Status: review

Development

Successfully merging this pull request may close these issues.

1 participant