Adding methods for building environment in the right order - #5057
Conversation
There was a problem hiding this comment.
Code Review
This pull request centralizes and refactors environment building and refreshing logic across various tmt modules by introducing Environment.build_environment and refresh_intrinsics methods, and establishes a common StepContext base class for step contexts. Feedback recommends correcting the environment variable precedence order in _build_environment to prevent guest-level variables from overriding test-level ones, and returning a copy of the environment in refresh_intrinsics to avoid modifying the cached environment in place.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
20f846a to
3b11a1f
Compare
|
/packit test |
9bbbf42 to
76808fc
Compare
Pull Request Checklist