Limit verbose/debug levels - #4836
Open
happz wants to merge 9 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request standardizes verbosity and debug levels by introducing dedicated type aliases and normalization functions for input validation. Feedback includes catching GeneralError in tmt/trying.py to prevent crashes, removing redundant None checks, and aligning the VerbosityLevel range with the help text. Additionally, restore the logging level in tmt/utils/init.py to avoid increased output noise.
LecrisUT
reviewed
Apr 30, 2026
happz
force-pushed
the
verbose-debug-levels-limited
branch
from
May 19, 2026 07:45
42ac9da to
6324bda
Compare
happz
marked this pull request as ready for review
May 19, 2026 07:45
happz
force-pushed
the
verbose-debug-levels-limited
branch
from
June 15, 2026 18:55
6324bda to
dd4cdea
Compare
happz
force-pushed
the
verbose-debug-levels-limited
branch
from
June 29, 2026 12:05
dd4cdea to
54034d1
Compare
happz
force-pushed
the
verbose-debug-levels-limited
branch
2 times, most recently
from
August 6, 2026 09:06
d8d7eb1 to
d1c51c4
Compare
LecrisUT
reviewed
Aug 10, 2026
Enforced in code by the use of `Literal` type alias, runtime check follow the `normalize_*` pattern. Updated documentation and help texts to reflect the change. Related to #4814.
happz
force-pushed
the
verbose-debug-levels-limited
branch
from
August 11, 2026 07:23
0e6479e to
8202ca6
Compare
LecrisUT
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enforced in code by the use of
Literaltype alias, runtime check follow thenormalize_*pattern. Updated documentation and help texts to reflect the change.Related to #4814.
Pull Request Checklist