Skip to content

Limit verbose/debug levels - #4836

Open
happz wants to merge 9 commits into
mainfrom
verbose-debug-levels-limited
Open

Limit verbose/debug levels#4836
happz wants to merge 9 commits into
mainfrom
verbose-debug-levels-limited

Conversation

@happz

@happz happz commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

Enforced in code by the use of Literal type alias, runtime check follow the normalize_* pattern. Updated documentation and help texts to reflect the change.

Related to #4814.

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@happz happz added the ci | full test Pull request is ready for the full test execution label Apr 28, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request standardizes verbosity and debug levels by introducing dedicated type aliases and normalization functions for input validation. Feedback includes catching GeneralError in tmt/trying.py to prevent crashes, removing redundant None checks, and aligning the VerbosityLevel range with the help text. Additionally, restore the logging level in tmt/utils/init.py to avoid increased output noise.

Comment thread tmt/trying.py Outdated
Comment thread tmt/trying.py Outdated
Comment thread tmt/log.py Outdated
Comment thread tmt/utils/__init__.py
@github-project-automation github-project-automation Bot moved this to backlog in planning Apr 29, 2026
Comment thread tmt/options.py
Comment thread tmt/log.py Outdated
Comment thread tmt/log.py
@happz
happz force-pushed the verbose-debug-levels-limited branch from 42ac9da to 6324bda Compare May 19, 2026 07:45
@happz
happz marked this pull request as ready for review May 19, 2026 07:45
@happz
happz requested a review from falconizmi as a code owner May 19, 2026 07:45
Comment thread tmt/utils/__init__.py Outdated
@happz happz moved this from backlog to review in planning May 19, 2026
@happz
happz force-pushed the verbose-debug-levels-limited branch from 6324bda to dd4cdea Compare June 15, 2026 18:55
@happz
happz force-pushed the verbose-debug-levels-limited branch from dd4cdea to 54034d1 Compare June 29, 2026 12:05
@happz
happz force-pushed the verbose-debug-levels-limited branch 2 times, most recently from d8d7eb1 to d1c51c4 Compare August 6, 2026 09:06
Comment thread docs/overview.rst Outdated
Comment thread tmt/log.py Outdated
Comment thread tmt/log.py
happz added 8 commits August 11, 2026 09:16
Enforced in code by the use of `Literal` type alias, runtime check
follow the `normalize_*` pattern. Updated documentation and help texts
to reflect the change.

Related to #4814.
@happz
happz force-pushed the verbose-debug-levels-limited branch from 0e6479e to 8202ca6 Compare August 11, 2026 07:23
Comment thread tests/plan/import/basic.sh Outdated
@psss psss added this to the 1.78 milestone Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci | full test Pull request is ready for the full test execution

Projects

Status: review

Development

Successfully merging this pull request may close these issues.

4 participants