Skip to content

fix(ci): move the repo user-agent to where pnpm v12 reads it #10552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zkochan wants to merge 4 commits into
base: master
Choose a base branch
from
+9 −9
Open

fix(ci): move the repo user-agent to where pnpm v12 reads it #10552

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87391d8
fix(ci): drop the dead .npmrc user-agent and its per-release append
zkochan Jul 31, 2026
f80b0a2
fix(ci): move repo user-agents to pnpm v12 config
zkochan Jul 31, 2026
d06d5b6
Merge branch 'master' into fix-npmrc-user-agent-append
GiladShoham Sep 1, 2026
eef2eb1
Merge branch 'master' into fix-npmrc-user-agent-append
github-actions[bot] Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -688,16 +688,13 @@ jobs:
- run: cd bit && bbit init
- run:
name: bbit install
# the user-agent append labels registry requests from CI installs (the committed .npmrc
# says bit-repo-local). skip-worktree keeps the mutation out of any later commit made
# from this workspace (e.g. the version-bump commit of `bit ci merge`, which stages all
# tracked changes) — without it, a duplicate user-agent line lands on master every
# release and, being last in the file, overrides bit-repo-local for local installs too.
# the flag lives in .git/index, so it survives persist_to_workspace into later jobs.
# pnpm v12 stores the project user-agent in pnpm-workspace.yaml. Override the tracked
# local marker only in this CI worktree, then keep the temporary change out of later
# commits made from the persisted checkout (notably the release version bump).
command: >
cd bit &&
echo "user-agent=bit-repo-circleci" >> .npmrc &&
git update-index --skip-worktree .npmrc &&
pnpm config set --location=project userAgent bit-repo-circleci &&

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Sep 1, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. Unprovisioned pnpm command 🐞 Bug ☼ Reliability

setup_harmony now invokes pnpm config set without running the repository's setup_pnpm command,
so a missing pnpm terminates the && chain before bbit install, while an ambient older pnpm may
write the setting somewhere other than pnpm-workspace.yaml. The repository explicitly provisions
and pins pnpm 12 for every existing direct pnpm workflow, but this job omits that setup.
Agent Prompt 
## Issue description
`setup_harmony` directly invokes `pnpm config set`, but the job does not install or pin pnpm. This can either fail the job or use a pnpm version that does not implement the expected v12 project-config behavior.

## Issue Context
The repository already defines `setup_pnpm`, which installs pnpm 12.0.0-rc.7 and exports its binary directory through `$BASH_ENV`. Add that setup to `setup_harmony` before the direct pnpm invocation, or invoke the explicitly provisioned v12 binary by another reliable mechanism.

## Fix Focus Areas
- .circleci/config.yml[264-279]
- .circleci/config.yml[671-698]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

git update-index --skip-worktree pnpm-workspace.yaml &&
bbit install
# `bbit install` compiles as part of the install, but that pass can fall back to the
# default TypeScript compiler for components whose env is still being imported - notably
Expand Down
1 change: 0 additions & 1 deletion .npmrc
View file
Open in desktop

This file was deleted.

4 changes: 4 additions & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
# Marks installs performed inside this repository at the registry, so the bit
# CLI repo's own traffic can be told apart from real users' installs. pnpm v12
# reads settings like this one here rather than from .npmrc.
userAgent: bit-repo
Loading