This repository was archived by the owner on Jun 10, 2026. It is now read-only.
Fix all dependency security advisories (pnpm audit 33 → 0) - #221
Open
mpsq wants to merge 8 commits into
Open
Conversation
Co-authored-by: Meril <mpsq@users.noreply.github.com>
Co-authored-by: Meril <mpsq@users.noreply.github.com>
Co-authored-by: Meril <mpsq@users.noreply.github.com>
Co-authored-by: Meril <mpsq@users.noreply.github.com>
Co-authored-by: Meril <mpsq@users.noreply.github.com>
Co-authored-by: Meril <mpsq@users.noreply.github.com>
Co-authored-by: Meril <mpsq@users.noreply.github.com>
Takes `pnpm audit` to zero in both all-dependency and production scope, on top of the four overrides + rollup bump from the earlier work. Direct bumps: - ajv ^8.12.0 -> ^8.18.0 (GHSA-2g4f-4pwh-qvx6, production) - esbuild ^0.17.18 -> ^0.25.0 (GHSA-67mh-4wv8-2f99, dev/build-time only) Added pnpm overrides for narrowly-pinned transitives: - @isaacs/brace-expansion 5.0.1 (GHSA-7h2j-956f-4vf2) - brace-expansion 1.1.13 / 2.0.3 (GHSA-f886-m6hf-6m8v) - js-yaml 3.14.2 / 4.1.1 (GHSA-mh29-5h37-fv8m) - minimatch 3.1.4 / 4.2.5 / 9.0.7 / 10.2.3 (GHSA-3ppc-4f35-3m26, GHSA-7r86-cg39-jmmj, GHSA-23c5-xmqv-rm74) - yaml 1.10.3 (GHSA-48c2-rrv3-qjmp)
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Takes
pnpm auditfrom 33 → 0 advisories by pinning every advisory-affected dependency to a patched version, in both all-dependency and production scope.This branch is based on #220 (still open), so this PR contains the full set and reads as a single 33→0 change. Merging this supersedes the need to merge #220 separately; if #220 is preferred as the review unit, this branch can instead be merged into it.
What's included
From the earlier work (#220), advisories 33 → 20: overrides for
immutable3.8.3,lodash4.18.1,tmp0.2.7,ws8.21.0; arollupbump to^3.30.0; and caret refreshes that pick upshell-quote1.8.4 andfast-uri3.1.2.This change, advisories 20 → 0:
^8.12.0→^8.18.0^0.17.18→^0.25.05.0.11.1.13,2.0.33.14.2,4.1.13.1.4,4.2.5,9.0.7,10.2.31.10.3The
pnpm.overridesblock now has 14 entries (the 4 from #220 + 10 here). Theminimatch@10and@isaacs/brace-expansionoverrides are currently no-ops in the resolved tree (the patched minimatch versions no longer pull those vulnerable variants) — kept as defense against reintroduction.Validation
pnpm audit— no known vulnerabilitiespnpm audit --prod— no known vulnerabilitiespnpm install --frozen-lockfile— package.json and lockfile in syncpnpm build— passes (verified theesbuild0.17 → 0.25 bump works throughrollup-plugin-esbuild@5.0.0; dist output intact, norollup-plugin-esbuild@6bump needed)pnpm test— 34/34 passpnpm codegen— produces no change attributable to this PR (see note)Lockfile regenerated with
pnpm install(pnpm 10, matching CI) —lockfileVersion: '9.0'unchanged.Notes for reviewers
rollup-plugin-esbuild; the dev server flagged by GHSA-67mh-4wv8-2f99 is never started, so the advisory isn't exploitable here — the bump is purely to clear the audit. Build + tests + dist output all confirmed clean on 0.25.pnpm codegenregeneratessrc/graphql/types.tsandsrc/webhooks/webhook-schema.{json,ts}from the live Plain API, which has drifted since those snapshots were last committed (this is true onmain/Fix dependency security vulnerabilities #220 as well). To prove the drift is unrelated to the dependency changes, codegen was run against both the new deps and the baseline Fix dependency security vulnerabilities #220 deps with the network held constant — the generated output was byte-for-byte identical (matching sha256) in both. Those regenerated files are intentionally not included here; this PR is dependency-only (package.json+pnpm-lock.yaml).Note
Medium Risk
Direct esbuild major jump affects the Rollup build path; overrides broadly reshape the transitive tree though validation reportedly passed.
Overview
Clears pnpm audit by changing only
package.jsonandpnpm-lock.yaml—no application source.Direct version bumps: production
ajvto ^8.18.0; dev esbuild ^0.25.0 and rollup ^3.30.0 (build toolchain). The lockfile refreshes transitive picks (e.g.lodash,js-yaml,minimatch,ws,tmp,immutable,yaml).New
pnpm.overrides: fourteen pinned versions for advisory-affected transitives (immutable,lodash,tmp,ws,@isaacs/brace-expansion,brace-expansion1/2,js-yaml3/4,minimatch3/4/9/10,yaml@1), including some defensive pins that may not currently appear in the resolved tree.esbuild 0.17 → 0.25 is the main compatibility surface (used via
rollup-plugin-esbuildat build time); PR description notes build/tests were verified.Reviewed by Cursor Bugbot for commit 6a07e7c. Bugbot is set up for automated code reviews on this repo. Configure here.