fix(flow-producer): reject deduplication and debounce options (#2780)

[mohanrajvenkatesan23-04]

Why

FlowProducer.add() and addBulk() silently dropped opts.deduplication / opts.debounce. A dedup hit returns the existing job's id rather than the freshly generated one, which orphans the flow's children — there is no safe way to reconcile the two ids inside the multi-exec transaction.

Per maintainer @roggervalf on #2780:

"actually this won't work for a root parent either using flow producer because the parent ids should be known in each addition before running the transaction. Dedup logic can retrieve a different id than the one being generated from the producer."
"this functionality is not supported... We should throw an error in this case."

Closes #2780.

What

• src/classes/flow-producer.ts: file-private assertNoDeduplication(flow) helper called at the top of add() and addBulk(). Throws a clear error naming the offending queue/job.
• tests/flow.test.ts: three regression tests covering deduplication on add(), debounce on add(), and deduplication mixed into addBulk().

I left the FlowJob type alone for now — removing debounce/deduplication from the root type would be a TypeScript breaking change that warrants a separate decision. The runtime check covers JS users and any TS escape hatch.

Test plan

• tests/flow.test.ts adds three new cases under "when deduplication or debounce is provided to a flow"
• CI runs the existing flow test suite against redis@7-alpine, valkey@8, and dragonflydb@latest

[Copilot]

Pull request overview

This PR makes FlowProducer fail fast when deduplication or debounce options are provided in flow jobs, because these options can cause the returned job id to differ from the id generated inside the flow transaction—breaking parent/child linking and orphaning children.

Changes:

• Add a runtime guard (assertNoDeduplication) in FlowProducer.add() and addBulk() that throws a descriptive error when opts.deduplication/opts.debounce is present.
• Add regression tests ensuring add() rejects both deduplication and debounce, and addBulk() rejects flows containing deduplication.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
src/classes/flow-producer.ts	Adds a guard to reject deduplication/debounce options in flows with a clear error message.
tests/flow.test.ts	Adds tests covering rejection behavior for flow creation with deduplication/debounce.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mohanrajvenkatesan23-04]

Thanks for the review! Pushed a follow-up commit addressing both points:

• src/classes/flow-producer.ts — assertNoDeduplication now walks the full tree instead of only checking the root. It accepts FlowJob | FlowChildJob and recurses into children, so a deduplication or debounce option on any nested node is rejected with the same error. FlowChildJob omits both options at the type level, but JavaScript callers (and TS escape hatches) can still set them, and addChildren() would otherwise pass them straight through to Job.addJob.
• tests/flow.test.ts — added an addBulk() case for debounce mirroring the existing deduplication case, plus a new test covering nested child and grandchild nodes for both options.