fix: set validator registration value to 1000uT - #7457
Merged
Conversation
Contributor
WalkthroughRaised the vn_registration_min_deposit_amount from MicroMinotari(0) to MicroMinotari(1000) in the localnet and igor consensus constant initializations; no public APIs or exported symbols changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
sdbondi
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
base_layer/transaction_components/src/consensus/consensus_constants.rs (2)
491-494: Use uT constant and clarify unit in the noteTiny readability/consistency win: elsewhere this file uses the uT unit helper. Also make the comment explicit about units.
- // NOTE: the transaction builder checks that you aren't sending less funds than the fee cost. This causes a - // registration sending 0 to fail. Send 1000 to cover for this. - vn_registration_min_deposit_amount: MicroMinotari(1000), + // NOTE: the transaction builder checks that you aren't sending less funds than the fee cost. This causes a + // registration sending 0 to fail. Send 1_000 uT to cover this. + vn_registration_min_deposit_amount: 1_000 * uT,
562-562: Mirror localnet’s comment and use uT for consistencyMatch the explanatory comment and representation used in localnet().
- vn_registration_min_deposit_amount: MicroMinotari(1000), + // See localnet note: enforce a non-zero amount so fees are covered (1_000 uT). + vn_registration_min_deposit_amount: 1_000 * uT,
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
base_layer/transaction_components/src/consensus/consensus_constants.rs(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
- GitHub Check: test (nextnet, nextnet)
- GitHub Check: test (mainnet, stagenet)
- GitHub Check: test (testnet, esmeralda)
- GitHub Check: ci
- GitHub Check: cargo check with stable
- GitHub Check: wasm build tests
- GitHub Check: ledger build tests
- GitHub Check: Cucumber tests / FFI
- GitHub Check: Cucumber tests / Base Layer
🔇 Additional comments (1)
base_layer/transaction_components/src/consensus/consensus_constants.rs (1)
491-494: Sanity-check igor/localnet deposit settings
- ConsensusConstants entries at lines 620, 732, 787, and 895 still set
vn_registration_min_deposit_amounttoMicroMinotari(0); update toMicroMinotari(1000)if igor/localnet should enforce the new minimum.- No other code or tests reference a zero deposit; manually verify no in-flight 0-deposit registrations exist on those networks to avoid post-upgrade divergence.
Member
Author
|
Just found the setting to turn that check off in the wallet, however it may be better to use a non-zero registration amount but no rush to merge |
SWvheerden
pushed a commit
to SWvheerden/tari
that referenced
this pull request
Sep 1, 2025
Description --- fix: set validator registration value to 1000uT for localnet and igor Motivation and Context --- The transaction builder checks that you aren't sending less funds than the fee cost. This causes a registration sending 0 to fail. Send 1000 to cover for this. How Has This Been Tested? --- Tested registration in tari-ootle PR (tari-project/tari-ootle#1560) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Raised the minimum validator node registration deposit to 1000 MicroMinotari on localnet and Igor. * Users registering validator nodes on these networks must now provide at least 1000 MicroMinotari as a deposit. * No changes to public APIs or user interfaces; impact is limited to validator registration requirements. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
SWvheerden
pushed a commit
that referenced
this pull request
Sep 1, 2025
Description --- fix: set validator registration value to 1000uT for localnet and igor Motivation and Context --- The transaction builder checks that you aren't sending less funds than the fee cost. This causes a registration sending 0 to fail. Send 1000 to cover for this. How Has This Been Tested? --- Tested registration in tari-ootle PR (tari-project/tari-ootle#1560) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Raised the minimum validator node registration deposit to 1000 MicroMinotari on localnet and Igor. * Users registering validator nodes on these networks must now provide at least 1000 MicroMinotari as a deposit. * No changes to public APIs or user interfaces; impact is limited to validator registration requirements. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: set validator registration value to 1000uT for localnet and igor
Motivation and Context
The transaction builder checks that you aren't sending less funds than the fee cost. This causes a
registration sending 0 to fail. Send 1000 to cover for this.
How Has This Been Tested?
Tested registration in tari-ootle PR (tari-project/tari-ootle#1560)
Summary by CodeRabbit