Skip to content

chore!: upgrade to minotari 5.0.0 #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sdbondi merged 4 commits into from
Sep 1, 2025
Merged

chore!: upgrade to minotari 5.0.0 #1560

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68f67b8
chore!: upgrade to minotari 5.0.0
sdbondi Aug 29, 2025
793996d
fix some of the cucumbers
sdbondi Sep 1, 2025
716a3c3
machete
sdbondi Sep 1, 2025
3b06c81
fixes
sdbondi Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,4 @@ clients/validator_node_grpc_client/package-lock.json
# moon
.moon/cache
.moon/docker
./cucumber-output-junit.xml

@coderabbitai coderabbitai Bot Sep 1, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Fix: pattern won’t match; use a root-anchored ignore

.gitignore doesn’t treat "./" specially. Use a leading slash to anchor to repo root so the file is actually ignored.

-./cucumber-output-junit.xml
+/cucumber-output-junit.xml
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
./cucumber-output-junit.xml
/cucumber-output-junit.xml
🤖 Prompt for AI Agents 
In .gitignore around line 65, the pattern "./cucumber-output-junit.xml" won't
match because .gitignore doesn't treat "./" specially; replace it with a
root-anchored pattern "/cucumber-output-junit.xml" so the file at the repo root
is actually ignored (remove the "./" and add the leading slash).

Loading
Loading