Repository navigation
Conversation
[Medium impact] The PR appears safe to merge. Reviews (1) · Last reviewed commit: "Update changelog" · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1595
Summary
With a prefix (e.g.
@import "tailwindcss" prefix(tw)), the theme variables Tailwind emits are prefixed:--tw-color-red-500,--tw-font-sans, etc. Completions insidevar(…)still suggested the unprefixed names, which don't exist in the output CSS.var(…),theme(…)and--theme(…)all get their items fromthemeKeyCompletions(), which usesresolveKnownThemeKeys(). That function strips the prefix, which is right fortheme(…)/--theme(…)but not forvar(…).This passes the helper name to
themeKeyCompletions()and, forvar(…)only, adds the prefix back to the label. Values and color previews are still resolved from the unprefixed key. Without a prefix the labels are unchanged.Test plan
Added two tests to
tests/completions/completions.test.js:var(…)withprefix(tw)suggests--tw-font-sansand--tw-color-custom(still shown as a color), and nothing unprefixed. Fails without this change (--font-sansis suggested instead).--theme(…)withprefix(tw)still suggests unprefixed keys. Passes before and after.The whole
tests/completions/completions.test.jsfile passes (48 tests). I also ranvitest runinpackages/tailwindcss-language-service(734 tests pass) andtsc --noEmitthere (no errors).