Skip to content

[stdlib] adjust assertion levels in UnsafeBufferPointer.extracting() #91514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
glessard merged 3 commits into from
Aug 19, 2026
Merged

[stdlib] adjust assertion levels in UnsafeBufferPointer.extracting() #91514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
298748e
[stdlib] relax UnsafeBufferPointer.extracting()
glessard Aug 14, 2026
e66713c
[test] remove extraneous availability guards
glessard Aug 16, 2026
d64dee6
[test] skip a test case when stdlib assertions are enabled
glessard Aug 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion stdlib/public/core/UnsafeBufferPointer.swift.gyb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,7 @@ extension Unsafe${Mutable}BufferPointer where Element: ~Copyable {
@export(implementation)
@safe
public func extracting(_ bounds: Range<Int>) -> Self {
_precondition(_checkBounds(bounds), "Index out of range")
_debugPrecondition(_checkBounds(bounds), "Index out of range")
guard let start = self.baseAddress else {
return unsafe Self(start: nil, count: 0)
}
Expand Down Expand Up @@ -592,6 +592,7 @@ extension Unsafe${Mutable}BufferPointer where Element: ~Copyable {
/// - Returns: A new buffer pointer over the items at `bounds`.
@export(implementation)
public func extracting(unchecked bounds: Range<Int>) -> Self {
_internalInvariant(_checkBounds(bounds), "Index out of range")
let newStart = unsafe _position?.advanced(by: bounds.lowerBound)
return unsafe Self(start: newStart, count: bounds.count)
}
Expand Down
3 changes: 2 additions & 1 deletion stdlib/public/core/UnsafeRawBufferPointer.swift.gyb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1222,7 +1222,7 @@ extension Unsafe${Mutable}RawBufferPointer {
@export(implementation)
@safe
public func extracting(_ bounds: Range<Int>) -> Self {
_precondition(_checkBounds(bounds), "Byte offset out of range")
_debugPrecondition(_checkBounds(bounds), "Byte offset out of range")
guard let start = baseAddress else {
return unsafe Self(_uncheckedStart: nil, count: 0)
}
Expand Down Expand Up @@ -1267,6 +1267,7 @@ extension Unsafe${Mutable}RawBufferPointer {
/// - Returns: A new buffer pointer over the bytes at `bounds`.
@export(implementation)
public func extracting(unchecked bounds: Range<Int>) -> Self {
_internalInvariant(_checkBounds(bounds), "Byte offset out of range")
let newStart = unsafe baseAddress?.advanced(by: bounds.lowerBound)
return unsafe Self(_uncheckedStart: newStart, count: bounds.count)
}
Expand Down
15 changes: 6 additions & 9 deletions validation-test/stdlib/UnsafeBufferPointer.swift.gyb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,6 @@ ${SelfName}TestSuite.test("rebasing") {
${SelfName}TestSuite.test("_checkBounds(_: Range) helper")
.require(.minimumStdlib(.stdlib_6_4))
.code {
guard #available(SwiftStdlib 6.4, *) else { return }

% if IsRaw:
let allocated = UnsafeMutableRawBufferPointer.allocate(byteCount: 20, alignment: 8)
let buffer = ${SelfType}(allocated)
Expand Down Expand Up @@ -173,8 +171,6 @@ ${SelfName}TestSuite.test("rebasingInvalidMutableSlice")
.require(.minimumStdlib(.stdlib_6_4))
.require(.crashTesting)
.code {
guard #available(SwiftStdlib 6.4, *) else { return }

let rawBuffer = UnsafeMutableRawBufferPointer.allocate(
byteCount: 32, alignment: 8
)
Expand Down Expand Up @@ -421,6 +417,11 @@ ${SelfName}TestSuite.test("extracting() functions")
expectEqual(sub3[capacity - 1], ${Element}(capacity - 1))
expectEqual(sub4[0], ${Element}(2))
expectEqual(sub5[0], ${Element}(1))

let empty1 = buffer.extracting(0..<0)
expectEqual(empty1.count, 0)
let empty2 = buffer.extracting(capacity..<capacity)
expectEqual(empty2.count, 0)
}

${SelfName}TestSuite.test("extracting() bounds checking")
Expand All @@ -437,6 +438,7 @@ ${SelfName}TestSuite.test("extracting() bounds checking")

${SelfName}TestSuite.test("extracting(unchecked:) functions")
.require(.stdlib_6_5)
.skip(.custom({ _isStdlibInternalChecksEnabled() }, reason: "Requires a release stdlib."))
.code {
let capacity = 32
% if IsRaw:
Expand All @@ -463,11 +465,6 @@ ${SelfName}TestSuite.test("extracting(unchecked:) functions")
let beyondClosed = prefix.extracting(unchecked: 16...23)
expectEqual(beyondClosed.count, 8)
expectEqual(beyondClosed[0], ${Element}(16))

let empty1 = buffer.extracting(unchecked: 0..<0)
expectEqual(empty1.count, 0)
let empty2 = buffer.extracting(unchecked: capacity..<capacity)
expectEqual(empty2.count, 0)
}

${SelfName}TestSuite.test("prefix extracting() functions")
Expand Down