[DNM] Remove thunk over objc_copyImageHeaders(). - #1826
Draft
grynspan wants to merge 2 commits into
Draft
Conversation
Our CI is now on an Xcode 27 beta, so it can directly invoke `objc_copyImageHeaders()`. No need for the `dlsym()`-calling thunk anymore.
grynspan
requested review from
briancroom,
harlanhaskins,
jerryjrchen and
stmontgomery
as code owners
August 9, 2026 23:29
grynspan
added
darwin
Contributor
Author
|
Primary Swift CI still uses an older Xcode, so need to double-check we don't break the toolchain build first. (May need to hold off on this change for a few years, or use |
grynspan
marked this pull request as draft
August 13, 2026 21:48
grynspan
changed the title
objc_copyImageHeaders().objc_copyImageHeaders().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our CI is now on an Xcode 27 beta, so it can directly invoke
objc_copyImageHeaders(). No need for thedlsym()-calling thunk anymore.Checklist: