Ensure attachments path directory is created by bkhouri · Pull Request #1788 · swiftlang/swift-testing

bkhouri · 2026-07-13T19:40:20Z

When running swift test --attachments-path /does/not/exist, the Swift Testing library will fail with an error like:

Invalid value "/path/does/not/exists" for argument ---attachments-path

Ensure the path specified by --attachments-path is created, and update the error message to remote the additional - in the argument name.

Closes #1665

Checklist:

Code and documentation should follow the style of the Style Guide.
If public symbols are renamed or modified, DocC references should be updated.
Update documentation to reflect behavioural changes

grynspan

This is a lot of new code just to create a directory. I'd suggest we just leverage Foundation for it unless we're doing it a lot. (So, yes, you did the right thing avoiding Foundation, but sometimes it's not worth the effort!)

grynspan · 2026-08-17T20:48:57Z

+      let actualPath = try #require(configuration.attachmentsPath, "Attachments path is not expected to be nil")
+      #expect(canonicalizePath(actualPath) == canonicalizePath(attachmentsPath))
+    #else
+    try Test.cancel("Test requires Foundation")


No, just mark the whole block of tests as #if canImport(Foundation) please, as is done elsewhere in our test suites.

I thought to mark the test skipped to get a sense of which tests were may not have been executed

Skip a test when it otherwise would run, but some runtime condition prevents it from doing so. If a test is entirely invalid in some configuration, it does not need to exist in that configuration.

Please make this change.

Done. I wrapped each test in a #if canImport(...) block to prevent adding a test case in between that should not be gated by said canImport. This makes it more explicit which tests should be gated by the #if canImport(...)

That's not what I asked you to do, but it's sufficient for the purposes of this PR.

When running `swift test --attachments-path /does/not/exist`, the Swift Testing library will fail with an error like: ``` Invalid value "/path/does/not/exists" for argument ---attachments-path ``` Ensure the path specified by `--attachments-path` is created, and update the error message to remote the additional `-` in the argument name. Closes swiftlang#1665

bkhouri force-pushed the t/main/gh1665_create_attachment-path-if-it-does-not-exists branch from cb47ad0 to aab38cf Compare July 13, 2026 19:52

grynspan requested changes Jul 15, 2026

View reviewed changes

grynspan assigned bkhouri Jul 15, 2026

grynspan added tools integration 🛠️ Integration of swift-testing into tools/IDEs command-line experience ⌨️ enhancements to the command line interface attachments/activities 🖇️ Work related to attachments and/or activities labels Jul 15, 2026

grynspan added this to the Swift 6.5.0 (main) milestone Jul 15, 2026

bkhouri force-pushed the t/main/gh1665_create_attachment-path-if-it-does-not-exists branch 2 times, most recently from 58f0c81 to 9b7fa6d Compare July 15, 2026 21:20

bkhouri requested a review from grynspan July 15, 2026 21:20

bkhouri force-pushed the t/main/gh1665_create_attachment-path-if-it-does-not-exists branch 2 times, most recently from e919a0e to 0388251 Compare July 15, 2026 22:03

bkhouri marked this pull request as ready for review July 15, 2026 22:04

bkhouri requested review from briancroom, harlanhaskins, jerryjrchen and stmontgomery as code owners July 15, 2026 22:04

bkhouri marked this pull request as draft July 15, 2026 22:04

bkhouri commented Jul 15, 2026

View reviewed changes

Comment thread Sources/Testing/Testing.docc/ReleaseNotes/Unreleased.md Outdated

grynspan requested changes Jul 15, 2026

View reviewed changes

Comment thread Sources/Testing/Testing.docc/Documentation.md Outdated