fix: allow Receiver display sleep during active sessions - #182
Draft
Betafer wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
SDL fullscreen inhibition and the Sender's capture activity previously kept the iMac panel awake indefinitely. Simply removing the assertion is unsafe because the virtual display can stop producing frames. Separating the physical Receiver panel policy from the Sender capture policy lets the panel sleep without tearing down the session.
Compatibility
The new heartbeat fields are optional. Older heartbeats still decode, and an older Receiver ignores the additional JSON fields.
Validation
TBDisplaySenderXcode tests pass, including heartbeat compatibility coverageThis PR is limited to active-session display power policy and its wire-compatible activity signal.