Fix repeated Studio builds and Sandbox cleanup #29
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -108,6 +108,7 @@ type ProjectV2StorageMode = "checking" | "cloud" | "local"; | |
| export interface ProjectV2StudioSurfaceProps { | ||
| project: ProjectV2; | ||
| provider: ProjectProvider; | ||
| autoBuildRequestId?: string | null; | ||
| onProjectChange: (project: ProjectV2, storageRevision?: number) => void; | ||
| onAgentEvent?: (event: { | ||
| phase: "snapshot" | "sandbox" | "verification" | "preview"; | ||
|
|
@@ -332,6 +333,7 @@ export const ProjectV2StudioSurface = forwardRef< | |
| >(function ProjectV2StudioSurface({ | ||
| project, | ||
| provider, | ||
| autoBuildRequestId = null, | ||
| onProjectChange, | ||
| onAgentEvent, | ||
| onNotify, | ||
|
|
@@ -611,6 +613,8 @@ export const ProjectV2StudioSurface = forwardRef< | |
| const controller = new AbortController(); | ||
| builderAbort.current = controller; | ||
| let statusTimer: ReturnType<typeof setInterval> | null = null; | ||
| let runtimeReadyObserved = false; | ||
| let runSettled = false; | ||
| setBusy("task:build"); | ||
| setAgentState("running"); | ||
| setAgentSummary( | ||
|
|
@@ -642,9 +646,33 @@ export const ProjectV2StudioSurface = forwardRef< | |
| status: "active", | ||
| message: "Starting the isolated Node 24 Sandbox and syncing real project files…", | ||
| }); | ||
| const refreshBuildProgress = async () => { | ||
| const state = await refreshSandboxStatus(snapshot.project.id); | ||
| if ( | ||
| runSettled | ||
| || controller.signal.aborted | ||
| || runtimeReadyObserved | ||
| || state.status !== "running" | ||
| ) { | ||
| return; | ||
| } | ||
| runtimeReadyObserved = true; | ||
| activePhase = "verification"; | ||
| onAgentEvent?.({ | ||
| phase: "sandbox", | ||
| status: "done", | ||
| message: "The isolated Node 24 Sandbox is running.", | ||
| }); | ||
| onAgentEvent?.({ | ||
| phase: "verification", | ||
| status: "active", | ||
| message: "Installing dependencies and running the declared checks…", | ||
| }); | ||
| }; | ||
| statusTimer = setInterval(() => { | ||
| void refreshBuildProgress().catch(() => undefined); | ||
| }, 4_000); | ||
|
There was a problem hiding this comment.
When a build runs near the 270-second server deadline, this four-second interval issues roughly 68 AGENTS.md reference: AGENTS.md:L109-L109 Useful? React with 👍 / 👎. |
||
| void refreshBuildProgress().catch(() => undefined); | ||
| const response = await fetch("/api/builder/agent", { | ||
| method: "POST", | ||
| credentials: "same-origin", | ||
|
|
@@ -657,6 +685,7 @@ export const ProjectV2StudioSurface = forwardRef< | |
| provider: providerSelection(provider), | ||
| }), | ||
| }); | ||
| runSettled = true; | ||
| if (statusTimer) { | ||
| clearInterval(statusTimer); | ||
| statusTimer = null; | ||
|
|
@@ -665,11 +694,14 @@ export const ProjectV2StudioSurface = forwardRef< | |
| if (!payload.result) { | ||
| throw new Error(payload.error ?? "Builder agent returned no verifiable result."); | ||
| } | ||
| if (!runtimeReadyObserved) { | ||
| runtimeReadyObserved = true; | ||
| onAgentEvent?.({ | ||
| phase: "sandbox", | ||
| status: "done", | ||
| message: "Project files are running inside the isolated Node 24 Sandbox.", | ||
| }); | ||
| } | ||
| activePhase = "verification"; | ||
| onAgentEvent?.({ | ||
| phase: "verification", | ||
|
|
@@ -699,9 +731,6 @@ export const ProjectV2StudioSurface = forwardRef< | |
| message: "Live Sandbox preview is ready. You can keep chatting to edit multiple files.", | ||
| }); | ||
| } else { | ||
| onAgentEvent?.({ | ||
| phase: "verification", | ||
| status: "blocked", | ||
|
|
@@ -710,9 +739,7 @@ export const ProjectV2StudioSurface = forwardRef< | |
| } | ||
| return payload.result; | ||
| } catch (error) { | ||
| runSettled = true; | ||
| const cancelled = controller.signal.aborted; | ||
| const failure = cancelled | ||
| ? "Build stopped. Your saved files and last working preview are unchanged." | ||
|
|
@@ -737,38 +764,35 @@ export const ProjectV2StudioSurface = forwardRef< | |
| onNotify?.(failure); | ||
| return null; | ||
| } finally { | ||
| runSettled = true; | ||
| if (statusTimer) clearInterval(statusTimer); | ||
| if (builderAbort.current === controller) builderAbort.current = null; | ||
| activeRunRef.current = false; | ||
| if (mounted.current) setBusy(null); | ||
| } | ||
| }, [ | ||
| absorbBuilderResult, | ||
| onAgentEvent, | ||
| onNotify, | ||
| provider, | ||
| refreshSandboxStatus, | ||
| syncSnapshot, | ||
| ]); | ||
|
|
||
| useEffect(() => { | ||
| if ( | ||
| !autoBuildRequestId || | ||
| autoStarted.current === autoBuildRequestId || | ||
| storageMode !== "cloud" || | ||
| project.manifest.framework.name !== "nextjs" || | ||
| project.preview?.status === "ready" | ||
| ) { | ||
| return; | ||
| } | ||
| const key = `${AUTO_BUILD_KEY}:${project.id}:${autoBuildRequestId}`; | ||
| const lease = Number(window.sessionStorage.getItem(key)); | ||
| autoStarted.current = autoBuildRequestId; | ||
| if (Number.isFinite(lease) && Date.now() - lease < AUTO_BUILD_LEASE_MS) return; | ||
| window.sessionStorage.setItem(key, String(Date.now())); | ||
| const timer = window.setTimeout(() => { | ||
| void runBuilder( | ||
|
|
@@ -777,7 +801,14 @@ export const ProjectV2StudioSurface = forwardRef< | |
| ); | ||
| }, 50); | ||
| return () => window.clearTimeout(timer); | ||
| }, [ | ||
| autoBuildRequestId, | ||
| project.id, | ||
| project.manifest.framework.name, | ||
| project.preview?.status, | ||
| runBuilder, | ||
| storageMode, | ||
| ]); | ||
|
|
||
| const saveSnapshot = useCallback(async (next: ProjectV2) => { | ||
| if (storageMode === "local") { | ||
|
|
||
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever
buildLifecycleisrunningbut the five release checks are not yet complete,releaseEvidenceReadyremains false and the surrounding quality card keeps thefailedclass, whose stylesheet renders the card in red error colors. The newly added “Building and checking your app” message therefore appears inside a visual failure state during every normal build; add a running/pending class and reservefailedfor the blocked lifecycle.Useful? React with 👍 / 👎.