Making preprocessing more efficient by reducing parsing instances - #306
Closed
eitan-weinstein wants to merge 3 commits into
Closed
Making preprocessing more efficient by reducing parsing instances#306eitan-weinstein wants to merge 3 commits into
eitan-weinstein wants to merge 3 commits into
Conversation
eitan-weinstein
added this to the
Complete pipeline for the inclusion of new data libraries milestone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #305.
Following additional file parsing instance for continuous data extraction for plotting within
preprocess_fendl3.store_results()from #305, this PR changes the functiontendl_processing.parse_endf_file_level_data()to now be calledtendl_processing.parse_endf_data(), with the major functional change being the return of the entire parsed nested dictionary. This creates a stored variable in memory,endf_dictthat already contains all of the nuclear data from a single nuclide's TENDL file, without requiring that the file be parsed a second time for plotting.