Process mailchimp forms based on class name instead of id - #40
Open
slackero wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had the problem to use the Mailchimp extension twice on a page (constant in the footer and inside content). It always resulted in DOM errors – because id="mailchimp-form" isn't unique in this case.
Because I did not find a simple solution to load another template (Templates/Form/Index.html) to just use a completely different structure I have refactored the JavaScript.
Bit off-topic:
Would be great to have an option to select another template or just have access to the outer tt_content values. I thought to use a custom tt_content.layout value as condition but it's not available when the mailchimp form is rendered.