MCP: bound Athena trace ID lookups - #21
Merged
Merged
Conversation
Decode canonical ULID timestamps before raw-object selection and narrow resolved-session follow-ups to matching streams. Exact ID/session predicates now fall back to bounded stream/day partitions when the 1,000-path guard is exceeded, without weakening read scope enforcement. Tested across 301 default, 280 no-default-feature, and 321 cloud/MCP/Athena scenarios.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughAthena trace lookups derive bounded windows from ULIDs, fall back from object-path enumeration to day partitions when limits are exceeded, and restrict follow-up queries to streams found in matched events. ChangesBounded trace lookup
Sequence Diagram(s)sequenceDiagram
participant Backend.show
participant id_lookup_window
participant select
participant select_sql
participant load_store
participant event_streams
Backend.show->>id_lookup_window: derive ULID-centered Window
Backend.show->>select: request bounded selection
select->>select_sql: build object-path or partition SQL
select-->>load_store: return initially selected rows
load_store->>event_streams: extract matching event streams
load_store->>select: query matching context streams
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Derive one bounded window from both canonical ULID ids so compare avoids a seven-day raw-object selection while preserving the exact predicate. Add scenario coverage for job-prefixed ids and foreign-id fallback; the cloud feature matrix passes 322 tests.
Contributor
Author
|
Live validation on
The raw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
$pathlists to bounded stream/day partitions only for exact ID/session predicatesWhy
Live verification on
sie-gw-cfgshowedsynty_trace_listsucceeding whilesynty_trace_showon its returned ID attempted 6,034 raw objects and hit the 1,000-object guard.Verification
cargo test --locked— 301 passedcargo test --locked --no-default-features— 280 passedcargo test --locked --features s3,gcs,mcp-http,athena— 321 passedSummary by CodeRabbit