fix(#101): add hono adapter Database type override#100
Open
elGatoMantocko wants to merge 1 commit into
Open
Conversation
adds generic Database type override to hono adapter added test to ensure chained declarations preserve context type updated docs to include alternative hono declaration
elGatoMantocko
changed the title
Author
|
fixes #101 |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fix hono adapter type definitions.
What is the current behavior?
There is no way to override the DB context returned by the
withSupabasemiddleware without doing so in the Hono app itself.What is the new behavior?
Make the hono
withSupabaseadapter more type-aware. Allow Database type overrides in the hono middleware.Additional context
For growing projects, managing routes with hono's route helpers via sub-applications generally becomes best practice when scalaing a hono api. In those scenarios, it's common to see many hono "apps" or routes defined across a stack. This change allows users to just use the hono middleware without needing to pre-declare any context types.