POC: iceberg-testing conformance fixtures (submodule) - #6
Open
sungwy wants to merge 1 commit into
Open
Conversation
Add sungwy/iceberg-testing as a pinned git submodule with language-neutral conformance fixtures (type strings, the Appendix B bucket hash, delete-file decode). The JUnit harness that walks them is deferred (see conformance/README.md); the PyIceberg fork has the worked example.
There was a problem hiding this comment.
Pull request overview
Adds a proof-of-concept “conformance” entry point that documents and wires an iceberg-testing/ git submodule intended to host language-neutral Iceberg conformance fixtures (type-string roundtrip, Appendix B bucket-hash KAT vectors, and delete-file decoding by field-id). This is repository-level wiring/documentation only; the Java/JUnit harness to execute the fixtures is explicitly deferred to a follow-up.
Changes:
- Add
conformance/README.mddescribing the fixture surfaces and how consumers should walk/validate them. - Add
.gitmodulesentry for aniceberg-testingsubmodule pointing athttps://github.com/sungwy/iceberg-testing.git.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
conformance/README.md |
Documents the intended fixture surfaces and consumption workflow; notes the JUnit harness is deferred. |
.gitmodules |
Registers the iceberg-testing git submodule URL and path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POC pinning the language-neutral conformance fixtures from sungwy/iceberg-testing as a git submodule (
iceberg-testing/).Surfaces: type-string parse + re-serialize, the Appendix B bucket-hash Known-Answer-Test (incl. byte-boundary decimals), and delete-file decode by field-id.
The JUnit harness that walks them is deferred in this POC (no JVM build available to verify it here) — see
conformance/README.md. The worked example is the PyIceberg fork: sungwy/iceberg-python#1