Skip to content

Gracefully shut down sessions at application exit #2943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
rwols wants to merge 1 commit into
base: feat/asyncio
Choose a base branch
from
Draft

Gracefully shut down sessions at application exit #2943

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions boot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,11 @@
from .plugin.configuration import LspDisableLanguageServerInProjectCommand
from .plugin.configuration import LspEnableLanguageServerGloballyCommand
from .plugin.configuration import LspEnableLanguageServerInProjectCommand
from .plugin.core.aio import gather_and_flatten_exceptions
from .plugin.core.aio import run_coroutine
from .plugin.core.constants import ST_VERSION
from .plugin.core.css import load as load_css
from .plugin.core.logging import exceptions_log
from .plugin.core.open import g_opening_files
from .plugin.core.panels import PanelName
from .plugin.core.registry import LspCheckApplicableCommand
Expand Down Expand Up @@ -235,6 +237,10 @@ def plugin_unloaded() -> None:
class Listener(sublime_aio.EventListener):

async def on_exit(self) -> None:
exceptions_log(
"Error while closing sessions",
await gather_and_flatten_exceptions(*(wm._end_sessions() for wm in windows._windows.values())),
)
await kill_all_subprocesses()

def on_load_project_async(self, window: sublime.Window) -> None:
Expand Down