Repository navigation
Preserve counterexample path metadata - #278
Open
DicksonWu654 wants to merge 1 commit into
Open
DicksonWu654 wants to merge 1 commit into
DicksonWu654 wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fast-check 4 returns the shrink path as
counterexamplePath, but Rendezvousreads only the legacy
pathwhen reporting failures and omits the path fromsaved regression records. This loses useful diagnostics for a failing run.
Prefer
counterexamplePath, withpathas a fallback for older callers,and save it as an optional field. Existing records without the field still
load unchanged. The path is diagnostic shrink metadata, not an exact replay
trace; regression replay continues to use the saved seed and run count.
From a checkout with dependencies installed (
npm ci), run this from therepository root. The build and probe take less than a minute:
reporter()printsPath : 0:1; the separatepersistFailure()call saves"counterexamplePath":"0:1"in the JSON record printed next. Before thischange, both are absent. Exit status 1 is expected for the reported failure.
Validation on Linux, Node 24.20.0 / npm 11.19.0:
npm run lint -- --deny-warnings: zero warnings and errors.npm run fmt:check,npm run typecheck, andnpm run build: passed.npm test -- heatstroke.tests.ts persistence.tests.ts: 19 tests passed.npm test: all 160 tests passed across 11 files; run once.🤖 Generated with Claude Code