Repository navigation
Let streams skip partial blocks of a shared hub - #80
Merged
Merged
Conversation
UlysseCorbeil
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ForkableHub.WithoutPartials()returns the hub as abstream.ForkableSourceFactorywhose sources subscribe without partial blocks: the last partial of a block is delivered as the complete block and the others are dropped, the same handling the relayer gives a client that does not ask for partials.stream.WithoutPartialBlocks()makes a stream use it.firehose-core needs it to share one hub between firehose and substreams tier1 in the same process. Tier1's hub is fed with partial blocks; firehose's never is, because its live source does not ask for them. Firehose streams go through
SourceFromBlockNum,SourceFromCursorandSourceThroughCursor, which always subscribe with partials, so without this a shared hub would change what firehose streams on chains with flash blocks.Existing methods keep their behavior.