(Closes #2202) Update the generation of Fortran declarations to observe dependencies - #3344
(Closes #2202) Update the generation of Fortran declarations to observe dependencies#3344arporter wants to merge 20 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3344 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 399 399
Lines 56173 56174 +1
=========================================
+ Hits 56173 56174 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
The NEMO ITs failed because of character variables: I was proceeding to try and do something with the parse tree in UnsupportedFortranType but actually, it would probably be better to work on populating the |
|
Marking this as blocked for the moment because I want to investigate adding support for a |
|
Although things are now better, |
|
All the ITs passed. However, I've realised that the order of output is not guaranteed - if more than one Symbol has all its dependencies declared at a given point then we should sort those Symbols and declare them in alphabetical order. |
This is a relatively simple PR - it takes the inter-dependence handling out of
_gen_param_declsand puts it intogen_decls. This also then means we can delete_gen_param_decls. I've added tests for the various tricky cases described in the original Issue and they all pass now :-)