Repository navigation
FIX: expert mode option handling and add a Lodestar heap size dropdown - #2315
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flag placement bug (
src/share/serviceYaml.js)The "flag is not in the config yet, append it" path scanned the whole file for the last
--token. Sinceenv:comes aftercommand:, for Lodestar the last one is insideNODE_OPTIONS: --max-old-space-size=8192, and that is where the new flag went. Lodestar is the only client affected. Teku'sJAVA_OPTS: -Xmx6ghas a single dash.The same block was copy-pasted in four places (two Nethermind pruning defaults, the toggle write, the text write). It is now
addCommandEntry()in the newsrc/share/serviceYaml.js, which:command:blocknullwhen there is no command list, which the toggle path previously crashed onSix tests, including the Lodestar case as a regression test.
Lodestar max heap size dropdown
The free-text "Node Options" field is gone. Both Lodestar entries now carry an inline Max Heap Size select using Teku's exact GB list.
unitFactoron select options.ExpertWindowdivides on read and multiplies on write, so the dropdown speaks whole GB while the flag keeps Node's MB.NODE_OPTIONSsurvives a write.setEnvFlag()in the same helper module: it appends the flag to an existingNODE_OPTIONS, or adds the variable to theenvblock, turningenv: {}into a block mapping first. This is not hypothetical. The beacon's 8 GB default only arrived in FIX: run restart tasks in parallel, some smaller bugs #2254, and the validator ships with an emptyenv, so the old free-text field silently did nothing on a validator.Detect button placement and feedback (
ExpertWindow.vue)The row is a one-row grid and the button had
justify-self: endbut noalign-self, so a fixed-height<img>sat at the top of the 40px row. The title icon two rules below already centered itself that way. Addedalign-self: centerto.toggleTextBox .buttonOnand its.buttonOfftwin.The spinner became a blink:
animate-spintoanimate-pulse animate-duration-1000.animate-pulseis the app's own idiom, used by the skeleton loaders, and the explicit duration matters because tailwindcss-animated redefines pulse with a 2s cycle, longer than a detect usually takes, so the icon would barely dim before finishing. Confirmed in the compiled CSS that the duration utility lands after.animate-pulseand so actually overrides it.Verification
src, prettier andnpm run buildclean