Repository navigation
FIX: write EJECTOR_SCOPE as JSON and defer the 2.5.2 update scripts - #2313
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EJECTOR_SCOPEwas being written to the ValidatorEjector config as a Python dict repr ({'1': [123]}) instead of JSON ({"1":[123]}). The rendered value of theejector_scopefact was Python-literal-shaped, so older ansible-core versions coerced it into a dict and then serialized the repr into the file.This PR drops the intermediate fact and builds the JSON inline in the
lineinfilevalue, matching howoracle_allowlist_changes.yamlalready handles it. It also defers the 2.5.2 update scripts to a later release.Changes
tasks/2.5.0/ejector_changes.yaml: removed theejector_scopefact and build the JSON string inline in thelineinfilevalue. Theset_factnow only readsejector_image_tag, so the task is renamed to "Read current image tag".molecule/250/verify.yml: added twodebugdumps of the ValidatorEjector config (raw text and parsed YAML) after the user assertions, so the written line is visible in the test output.Verification
molecule test -s 250passes:EJECTOR_SCOPE: '{"2":[42]}'