Repository navigation
CHANGE: Nimbus engine API to http and --web3-url to --el - #2312
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nimbus was the only consensus client Stereum pointed at the engine API over websockets. It now uses
buildExecutionClientEngineRPCHttpEndpointUrl()like every other client, and the flag has moved to Nimbus's current name:--el=http://stereum-/<el>:8551Launcher
Two lines. Changed in both places that build the endpoint:
NimbusBeaconServicefor fresh installsServiceManager'scase "Nimbus"for later EL rewiringMigration 2.5.2
New
nimbus_engine_changes.yaml, wired intomain.yml, with three guarded steps:ws://stereum-…:8551tohttp://…, matched per URL so comma-joined multi-EL values convert entirely, and scoped tostereum-so an external EL keeps the operator's own scheme.--web3-url=to--el=, with no version guard (per your call:--ellanded in v23.3.0, pre-Dencun).restart-servicesrestarts both. The leaked sessions live on Besu's side, so the cap only clears when the EL restarts.Molecule 252
Five fixtures, registered in the CI matrix. Passes all seven actions including idempotence. Verified as non-vacuous by neutering each half:
not moved to httpexecution clients not touchedNotes from implementation
Three things that came out of building this rather than from the spec:
statbeforetouch, becausestate: touchcreates files. A dangling dependency id would have produced a phantom empty service config.select('match', '.*--datadir.*') | firstand throws on a command without--datadir. That fragility is still there for any real Lighthouse config missing--datadir, andignore_errorson the include does not catch it.