Repository navigation
FIX: Simplify Language Selector [DRAFT] - #2310
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three commits on
bug_fixes, ahead ofmain:pausewith a real readiness wait in the update-stereum verify play867e308 - FIX: Molecule test (predates this session)
controls/roles/update-stereum/molecule/full/verify.ymlpause: seconds: 60after the update reboot with a real wait:wait_for_connection(15s delay, 600s timeout), followed by adocker inspectretry loop (60 attempts, 10s apart) that polls until the beacon container reports a non-v2.0.0 Lighthouse image.This removes the race where verification could run before the post-reboot update script had finished.
e78cab2 - CHORE: bump version
launcher/package.jsonplus lockfile: 2.5.1 to 2.5.2.75fe8b4 - FIX: Simplify Language Selector (this session)
Language picker:
language-page/components/MenuBody.vueRewritten. Previously a vertical Swiper coverflow carousel: 27 languages rotating in 3D, roughly 3 readable at a time, no search, sorted by
localeCompareon the native name so scripts interleaved arbitrarily.Now a two-column grid in a bordered, scrollable panel:
!importantoverrideshandleScrolltemplate reference and the unusedthumbsrefsStyling aligned to the app palette:
#33393Ewith#4d7575hover (matching the existingLanguageBtn)text-gray-200andtext-gray-400instead ofopacity-70#447a75#85cac4rule frommain.cssappliesrow-end-11so it stops above the Next button instead of running underneath itstore/languages.jsenglishNameto every entry.poand Japanese wasjp, buti18n.jsregistersptandja, so picking either silently did nothing.Help and Settings while disconnected
The header holding those buttons only exists in
BaseLayout, and the login screen usesInstallationLayout, so neither was reachable. Routing to/settingmanually did not work either: its base layout starts a 2s service poll, which setsstereumStatus = falseand dropsReconnectModalover the page.Fixed by:
ServerHeaderon the login routeSupportModalinInstallationLayoutStandaloneLayout.vue, a header/body/footer shell with no node tabs, no polling and no reconnect modal, plus a "Back to login" buttonSettingScreenchooses between the two layouts via a newsettingsStandaloneflag on thenodeHeaderstore, set bySingleMenufromroute.path === "/login"at click time