Remove the JavaScript code generator - #233
Merged
Merged
Conversation
leighmcculloch
marked this pull request as ready for review
August 18, 2026 21:24
leighmcculloch
requested review from
Ryang-21
and
a balanced review from Copilot
August 18, 2026 21:24
There was a problem hiding this comment.
Pull request overview
Removes the obsolete JavaScript generator and makes Go the CLI default.
Changes:
- Deletes JavaScript generator implementation and fixtures.
- Removes JavaScript registration and test coverage.
- Updates CLI defaults and documentation.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
README.md |
Updates generator documentation. |
lib/xdrgen/cli.rb |
Makes Go the default language. |
lib/xdrgen/generators.rb |
Removes JavaScript registration. |
lib/xdrgen/generators/javascript.rb |
Deletes JavaScript generator. |
spec/lib/xdrgen/generator_spec.rb |
Tests only Go generation. |
spec/output/generator_spec_javascript/block_comments.x/MyXDR_generated.js |
Deletes JavaScript fixture. |
spec/output/generator_spec_javascript/const.x/MyXDR_generated.js |
Deletes JavaScript fixture. |
spec/output/generator_spec_javascript/enum.x/MyXDR_generated.js |
Deletes JavaScript fixture. |
spec/output/generator_spec_javascript/nesting.x/MyXDR_generated.js |
Deletes JavaScript fixture. |
spec/output/generator_spec_javascript/optional.x/MyXDR_generated.js |
Deletes JavaScript fixture. |
spec/output/generator_spec_javascript/struct.x/MyXDR_generated.js |
Deletes JavaScript fixture. |
spec/output/generator_spec_javascript/test.x/MyXDR_generated.js |
Deletes JavaScript fixture. |
spec/output/generator_spec_javascript/union.x/MyXDR_generated.js |
Deletes JavaScript fixture. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
leighmcculloch
enabled auto-merge (squash)
August 18, 2026 21:27
Ryang-21
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove the JavaScript generator, its test fixtures, and its README and CLI references, making
gothe CLI's default language.Why
js-stellar-base and js-stellar-sdk v17 generate their XDR from the rs-stellar-xdr JSON AST instead, so nothing consumes this generator any more.