Skip to content

Remove the JavaScript code generator - #233

Merged
leighmcculloch merged 2 commits into
masterfrom
remove-javascript-generator
Aug 18, 2026
Merged

Remove the JavaScript code generator#233
leighmcculloch merged 2 commits into
masterfrom
remove-javascript-generator

Conversation

@leighmcculloch

@leighmcculloch leighmcculloch commented Aug 18, 2026

Copy link
Copy Markdown
Member

What

Remove the JavaScript generator, its test fixtures, and its README and CLI references, making go the CLI's default language.

Why

js-stellar-base and js-stellar-sdk v17 generate their XDR from the rs-stellar-xdr JSON AST instead, so nothing consumes this generator any more.

@leighmcculloch
leighmcculloch marked this pull request as ready for review August 18, 2026 21:24
@leighmcculloch
leighmcculloch requested review from Ryang-21 and a balanced review from Copilot August 18, 2026 21:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the obsolete JavaScript generator and makes Go the CLI default.

Changes:

  • Deletes JavaScript generator implementation and fixtures.
  • Removes JavaScript registration and test coverage.
  • Updates CLI defaults and documentation.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
README.md Updates generator documentation.
lib/xdrgen/cli.rb Makes Go the default language.
lib/xdrgen/generators.rb Removes JavaScript registration.
lib/xdrgen/generators/javascript.rb Deletes JavaScript generator.
spec/lib/xdrgen/generator_spec.rb Tests only Go generation.
spec/output/generator_spec_javascript/block_comments.x/MyXDR_generated.js Deletes JavaScript fixture.
spec/output/generator_spec_javascript/const.x/MyXDR_generated.js Deletes JavaScript fixture.
spec/output/generator_spec_javascript/enum.x/MyXDR_generated.js Deletes JavaScript fixture.
spec/output/generator_spec_javascript/nesting.x/MyXDR_generated.js Deletes JavaScript fixture.
spec/output/generator_spec_javascript/optional.x/MyXDR_generated.js Deletes JavaScript fixture.
spec/output/generator_spec_javascript/struct.x/MyXDR_generated.js Deletes JavaScript fixture.
spec/output/generator_spec_javascript/test.x/MyXDR_generated.js Deletes JavaScript fixture.
spec/output/generator_spec_javascript/union.x/MyXDR_generated.js Deletes JavaScript fixture.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md Outdated
@leighmcculloch
leighmcculloch enabled auto-merge (squash) August 18, 2026 21:27
@leighmcculloch
leighmcculloch merged commit 6f2c5b8 into master Aug 18, 2026
12 checks passed
@leighmcculloch
leighmcculloch deleted the remove-javascript-generator branch August 18, 2026 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants