internal/integration: use apply-load tooling from loadtest package in go-stellar-sdk - #185
Draft
cjonas9 wants to merge 6 commits into
Draft
internal/integration: use apply-load tooling from loadtest package in go-stellar-sdk#185cjonas9 wants to merge 6 commits into
cjonas9 wants to merge 6 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Horizon’s integration-ledger generator test to stop maintaining a local copy of the stellar-core apply-load orchestration logic and instead use the equivalent apply-load tooling that has been migrated into go-stellar-sdk (via ingest/loadtest). This aligns Horizon with the shared approach needed by other repos (e.g., stellar-rpc) that also need to generate ledgers/fixtures from apply-load.
Changes:
- Replaced the large, Horizon-local
apply-loadrunner + ledger/fixture streaming/verification helpers withloadtest.NewApplyLoad(...).RunApplyLoadAndWrite(...). - Upgraded
github.com/stellar/go-stellar-sdk(andgo-xdr) to pick up the newingest/loadtestpackage. - Marked now-unused direct deps (e.g.,
toml,klauspost/compress) as indirect ingo.mod.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/integration/generate_ledgers_test.go | Switches the test from Horizon-owned apply-load helper code to the SDK’s ingest/loadtest implementation. |
| go.mod | Bumps go-stellar-sdk/go-xdr versions and adjusts dependency directness. |
| go.sum | Updates sums to match the new module versions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cjonas9
marked this pull request as draft
May 6, 2026 16:22
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Structure
otherwise).
services/friendbot, orallordocif the changes are broad or impact manypackages.
Thoroughness
.mdfiles, etc... affected by this change). Take a look in the
docsfolder for a given service,like this one.
Release planning
CHANGELOG.mdwithin the component folder structure. For example, if I changed horizon, then I updated (CHANGELOG.md. I add a new line item describing the change and reference to this PR. If I don't update a CHANGELOG, I acknowledge this PR's change may not be mentioned in future release notes.semver, or if it's mainly a patch change. The PR is targeted at the next
release branch if it's not a patch change.
What
Removes
apply-loadtooling from*_test.gofile local to Horizon and uses similar tooling migrated to the SDK (see go-stellar-sdk/5940.Why
We are currently adding an ingestion test in
stellar-rpcthat usesstellar-core'sapply-loadtooling. As such, the infrastructure previously built out ingenerate_ledgers_test.gohas been moved to the SDK so it can be used by both repos. See stellar-rpc/711.Known limitations
N/A