Repository navigation
Add Socket Basics security scanning workflow - #386
Open
kanwalpreetd wants to merge 1 commit into
Open
kanwalpreetd wants to merge 1 commit into
kanwalpreetd wants to merge 1 commit into
Conversation
kanwalpreetd
force-pushed
the
main
branch
4 times, most recently
from
September 26, 2026 01:30
4cb9726 to
1148328
Compare
kanwalpreetd
marked this pull request as ready for review
September 28, 2026 12:40
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved workflow failure-handling and timeout issues block approval.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds scheduled/manual Socket Basics scanning for SAST, secrets, and Dockerfile issues.
Changes:
- Adds scanner configuration and exclusions.
- Adds Trivy and Semgrep ignore files.
- Adds a pinned GitHub Actions workflow with annotations.
Review findings include a critical false-success path, a moderate missing job timeout, and a nit regarding inaccurate Trivy documentation.
| File | Description |
|---|---|
.trivyignore |
Defines excluded Dockerfile rules. |
.socket-basics.json |
Configures Socket Basics scanners and exclusions. |
.semgrepignore |
Defines SAST scan exclusions. |
.github/workflows/socket-basics.yml |
Runs the scheduled Socket Basics scan. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Runs SAST through OpenGrep, secret scanning through TruffleHog, and
Dockerfile misconfiguration scanning through Trivy, submitting results
to Socket.dev.
.github/workflows/socket-basics.yml scheduled weekly + manual dispatch
.socket-basics.json scanner configuration
.semgrepignore SAST path exclusions
.trivyignore Dockerfile lint rules with no
security dimension (only present
where the repo has a Dockerfile)
Separate from socket-scan.yml, which covers dependency CVEs and Tier 1
reachability.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
@kanwalpreetd pr preview is failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More info: https://stellarorg.atlassian.net/wiki/spaces/SCRT/pages/5901680652/Socket+Basics+Integration+Guide