Destroy parallel apply state asynchronously. - #5414
Open
dmkozh wants to merge 1 commit into
Open
Conversation
The state data structures are rather large and nested (due to containing XDR), so when they get large de-allocation may take up to a few ms. We don't really need to block the apply thread on this de-allocation, so we can hide it in the background thread.
dmkozh
force-pushed
the
async_par_apply_cleanup
branch
from
August 14, 2026 20:12
83388a4 to
dd62ae8
Compare
dmkozh
marked this pull request as ready for review
August 14, 2026 20:15
Contributor
There was a problem hiding this comment.
Pull request overview
Defers destruction of large parallel Soroban apply-state structures to background workers.
Changes:
- Asynchronously destroys per-thread apply states.
- Heap-allocates and asynchronously destroys global apply state.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Destroy parallel apply state asynchronously.
The state data structures are rather large and nested (due to containing XDR), so when they get large de-allocation may take up to a few ms. We don't really need to block the apply thread on this de-allocation, so we can hide it in the background thread.
Checklist
clang-formatv8.0.0 (viamake formator the Visual Studio extension)