Drop interop-breaking SDK wildcard re-export from generated TS clients - #2691
Open
Galmanus wants to merge 1 commit into
Open
Drop interop-breaking SDK wildcard re-export from generated TS clients#2691Galmanus wants to merge 1 commit into
Galmanus wants to merge 1 commit into
Conversation
The generated src/index.ts re-exported the whole CommonJS SDK entrypoint with `export * from "@stellar/stellar-sdk"`, which Rollup/Vite cannot statically interop, producing "Unable to interop `export *`" warnings and dropped exports in consumer bundles (stellar#2352). Remove the flat wildcard re-export and keep the namespace re-exports (`contract`, `rpc`), which bundlers handle correctly. Regenerated the two fixtures and added a regression test that inits a fresh project and asserts the generated index.ts no longer carries the flat re-export.
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the generated TypeScript client’s interop-breaking Stellar SDK wildcard re-export while preserving namespace exports.
Changes:
- Removed the SDK root wildcard export from the template and fixtures.
- Added regression coverage for generated
index.ts.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/project_template/src/index.ts |
Removes the problematic wildcard export. |
src/boilerplate.rs |
Adds generation regression coverage. |
fixtures/test_custom_types/src/index.ts |
Updates the generated fixture. |
fixtures/test_constructor/src/index.ts |
Updates the generated fixture. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2352
What
Removes
export * from "@stellar/stellar-sdk"from the generated TypeScript client'ssrc/index.tstemplate, keeping the namespace re-exports (export * as contract,export * as rpc).Why
The SDK's root entrypoint is CommonJS. A flat
export *over a CJS module cannot be statically resolved by Rollup/Vite, which emitsUnable to interop \export *` in ... this may lose module exports` and silently drops exports in consumer bundles. The namespace re-exports do not hit this path and are preserved.How
project_template/src/index.tstest_constructor,test_custom_types)test_index_ts_has_no_interop_breaking_wildcard_reexport) that runsinitinto a temp dir and asserts the generatedindex.tsno longer contains the flat re-export while keeping the namespace onesTesting
main(verified by re-adding the line) and passes with this changecargo test -p soroban-spec-typescript: 26 passedcargo clippy -p soroban-spec-typescript --all-targets: clean