Skip to content

Disable resource limits in bn254 wasm test - #410

Merged
leighmcculloch merged 3 commits into
mainfrom
bn254-test-disable-resource-limits
Jul 23, 2026
Merged

Disable resource limits in bn254 wasm test#410
leighmcculloch merged 3 commits into
mainfrom
bn254-test-disable-resource-limits

Conversation

@leighmcculloch

@leighmcculloch leighmcculloch commented Jul 23, 2026

Copy link
Copy Markdown
Member

What

Disable resource limits in the import_ark_bn254 example.

Why

Env::default() in tests enforces mainnet limits. The refresh in stellar/rs-soroban-sdk#1946 (issue stellar/rs-soroban-sdk#1931) updates those limits to match current mainnet, lowering the per-transaction instruction ceiling from 600,000,000 to the true value of 400,000,000. This example consumes ~404,556,039 instructions, so under the refreshed ceiling it panics with HostError: Error(Budget, ExceededLimit).

Known limitations

N/A


Generated by Claude Code

Copy link
Copy Markdown
Member Author

The failing build-and-test (account, latest, …) check is a transient CI infrastructure error, not a problem with this change. The job died during setup while downloading the stellar-cli binary — curl: (35) Recv failure: Connection reset by peer — before anything compiled or ran. This diff only touches import_ark_bn254/src/test.rs, so it can't affect the account example. It should clear on a re-run of the failed job.


Generated by Claude Code

@leighmcculloch
leighmcculloch marked this pull request as ready for review July 23, 2026 05:56
Copilot AI review requested due to automatic review settings July 23, 2026 05:56
@leighmcculloch
leighmcculloch requested review from dmkozh and mootz12 July 23, 2026 05:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables Mainnet resource-limit enforcement for the intentionally expensive BN254 WASM test.

Changes:

  • Documents why the WASM test exceeds production limits.
  • Calls disable_resource_limits() alongside the unlimited budget reset.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread import_ark_bn254/src/test.rs
@leighmcculloch
leighmcculloch enabled auto-merge (squash) July 23, 2026 22:09
@leighmcculloch
leighmcculloch merged commit 3c19c8f into main Jul 23, 2026
134 checks passed
@leighmcculloch
leighmcculloch deleted the bn254-test-disable-resource-limits branch July 23, 2026 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

InvocationResourceLimits::mainnet() is out of date with actual Mainnet network settings

4 participants