Skip to content

Shrink the CI cargo-hack feature powerset - #563

Merged
leighmcculloch merged 2 commits into
mainfrom
group-type-enum-serde-ignored
Jul 28, 2026
Merged

Shrink the CI cargo-hack feature powerset#563
leighmcculloch merged 2 commits into
mainfrom
group-type-enum-serde-ignored

Conversation

@leighmcculloch

@leighmcculloch leighmcculloch commented Jul 28, 2026

Copy link
Copy Markdown
Member

What

Group the type_enum, serde_ignored, and test_feature features into the existing cargo-hack --group-features group used by the CI feature powerset runs.

Why

Every ungrouped feature doubles the powerset, so these three account for most of it: the feature combinations drop from 112 to 24, taking the build and test matrices from about 450 jobs to 98 per CI run. Extracted out of #562.

Known limitations

Grouped features are only ever enabled together, so combinations enabling any of the three independently of the rest of the group are no longer covered. All three are still compiled and tested as part of the group.

@leighmcculloch leighmcculloch changed the title Group type_enum and serde_ignored in CI powerset Shrink the CI cargo-hack feature powerset Jul 28, 2026
@leighmcculloch
leighmcculloch force-pushed the group-type-enum-serde-ignored branch from 9a59cab to d26e03e Compare July 28, 2026 12:48
@leighmcculloch
leighmcculloch requested a review from a team July 28, 2026 12:49
@leighmcculloch
leighmcculloch marked this pull request as ready for review July 28, 2026 12:49
Copilot AI review requested due to automatic review settings July 28, 2026 12:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Groups three additional features into the CI cargo-hack powerset group, reducing redundant build and test combinations.

Changes:

  • Groups type_enum, serde_ignored, and test_feature.
  • Applies the same grouping to publish dry runs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

leighmcculloch added a commit that referenced this pull request Jul 28, 2026
@leighmcculloch
leighmcculloch added this pull request to the merge queue Jul 28, 2026
Merged via the queue into main with commit a2485be Jul 28, 2026
110 checks passed
@leighmcculloch
leighmcculloch deleted the group-type-enum-serde-ignored branch July 28, 2026 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants