Generate contract specs as const ScSpecEntryRef - #1964
Closed
leighmcculloch wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Superseded by: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Generate every contract spec entry — types, events, and functions — as a const
ScSpecEntryRefvalue that the contract crate encodes to XDR at compile time, instead of encoding it inside the macro and emitting an opaque byte-string literal.Why
The spec a macro produces is currently invisible in expanded code and unreachable from Rust, so it can only be inspected by decoding the bytes out of the built wasm; a const value can be read in
cargo expandand reused by other generated code. Spec section bytes are unchanged for all 43 test contracts.Known limitations
Depends on stellar/rs-stellar-xdr#562 for the borrowing
*Reftypes and their const XDR serializers, so this carries a[patch.crates-io]pin on a stellar-xdr git rev until that lands and is released. Spec shaking still encodes the spec at macro time to compute its marker hash.