Skip to content

Bump stellar-xdr for SCSpecTypeUDTV2 - #1714

Closed
leighmcculloch wants to merge 2 commits into
mainfrom
scspec-udt-v2-id-field-9jgp9b
Closed

Bump stellar-xdr for SCSpecTypeUDTV2#1714
leighmcculloch wants to merge 2 commits into
mainfrom
scspec-udt-v2-id-field-9jgp9b

Conversation

@leighmcculloch

@leighmcculloch leighmcculloch commented Jul 29, 2026

Copy link
Copy Markdown
Member

Warning

Depends on unmerged and unreleased changes in:

A valid merge order for the whole stack:

  1. Add SCSpecTypeUDTV2 with a type id stellar-xdr#310 — add SCSpecTypeUDTV2 to the contract spec XDR
  2. Add borrowed Ref variants of generated types rs-stellar-xdr#560 — borrowed Ref variants of the generated types
  3. Add const XDR serialization on View types rs-stellar-xdr#562 — const XDR serialization on those Ref types
  4. Regenerate with SCSpecTypeUDTV2 rs-stellar-xdr#564 — regenerate with SCSpecTypeUDTV2
  5. this PR
  6. Encode contract spec XDR at const evaluation time rs-soroban-sdk#1965 — encode contract spec XDR at const evaluation time
  7. Reference user-defined types by id rs-soroban-sdk#1966 — reference user-defined types by id

What

Move the pinned stellar-xdr rev forward to the regeneration that adds ScSpecTypeUdtv2 and its ScSpecTypeDef::UdtV2 variant.

Why

Nothing here reads or constructs the new variant — the host does not reference ScSpecTypeDef at all — so this has no effect on host behavior and needs no host code changes. It is here because rs-soroban-env pins stellar-xdr by rev, and that pin has to move to the rev carrying SCSpecTypeUDTV2 before an rs-soroban-env release can be cut against it. Landing it as its own change keeps the mechanical bump separate from the SDK work that actually uses the variant.

Known limitations

No test exercises the change, because nothing in the host touches the new variant; the coverage lives downstream in the SDK. Pins an unmerged rs-stellar-xdr branch, so check-git-rev-deps fails until that lands and the pin moves to a merged commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant