Bump stellar-xdr for SCSpecTypeUDTV2 - #1714
Closed
leighmcculloch wants to merge 2 commits into
Closed
Conversation
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Depends on unmerged and unreleased changes in:
A valid merge order for the whole stack:
SCSpecTypeUDTV2to the contract spec XDRRefvariants of the generated typesReftypesSCSpecTypeUDTV2What
Move the pinned
stellar-xdrrev forward to the regeneration that addsScSpecTypeUdtv2and itsScSpecTypeDef::UdtV2variant.Why
Nothing here reads or constructs the new variant — the host does not reference
ScSpecTypeDefat all — so this has no effect on host behavior and needs no host code changes. It is here becausers-soroban-envpinsstellar-xdrby rev, and that pin has to move to the rev carryingSCSpecTypeUDTV2before anrs-soroban-envrelease can be cut against it. Landing it as its own change keeps the mechanical bump separate from the SDK work that actually uses the variant.Known limitations
No test exercises the change, because nothing in the host touches the new variant; the coverage lives downstream in the SDK. Pins an unmerged
rs-stellar-xdrbranch, socheck-git-rev-depsfails until that lands and the pin moves to a merged commit.