SPIKE: Protocol 28 (CAP-0085) - #60
Draft
sisuresh wants to merge 2 commits into
Draft
Conversation
…utable_ref Pin stellar-xdr to sisuresh/rs-stellar-xdr@e1170cd9 (PR #553, xdr submodule stellar-xdr#308 head 76218a99). Enable cap_0085_executable_ref, adding the ContractExecutableExternalRef type (externally-managed contract executables). Disable wasm-opt for the pre-release dep. Regen list_of_types test.
…revision dup (SPIKE)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SPIKE for Protocol 28 (CAP-0085 — externally managed contract executables). Bumps the WASM XDR↔JSON codec's
stellar-xdrto the CAP-0085 pre-release.Changes
stellar-xdr→sisuresh/rs-stellar-xdr@e1170cd9(rs-stellar-xdr#553; xdr submodule = stellar-xdr#308 head76218a99), featurecap_0085_executable_ref(basemainenables no cap flags, so only this one is added — notcap_0083/cap_0084).ContractExecutableExternalRefinlist_of_typestest.wasm-opt = false(local binaryen rejects the pre-release dep's bulk-memory ops).deny.toml: allow the fork git source + skipcrate-git-revisiondup (SPIKE-only).Deferred
wasm-pack test(headless firefox) not run locally; nativecargo testpasses — relies on CI for the browser leg.Upstream: stellar/rs-stellar-xdr#553 (canonical
.x: stellar/stellar-xdr#308).Downstream: stellar/laboratory (consumes
@stellar/stellar-xdr-json).