fix: reject section-marker addresses and role+number orgs#403
Draft
cursor[bot] wants to merge 3 commits into
Draft
fix: reject section-marker addresses and role+number orgs#403cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
Place-of-performance cues were keeping bare section ids (6.1) as addresses, and municipality prefix cues captured page footers such as Strana 7 as organizations. Reject those shapes via shared filters. Co-authored-by: Jan Kubica <jan-kubica@users.noreply.github.com>
Co-authored-by: Jan Kubica <jan-kubica@users.noreply.github.com>
Co-authored-by: Jan Kubica <jan-kubica@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Czech Registr smluv evaluation on a recent mandate agreement found two clear scaffolding false positives:
6.1).města/ shared role vocabulary) captured page footers as organizations (Strana 7).Before / after
Negative control: ordinary municipality captures such as
město Brandýs nad Labemremain organizations.Approach
Tests
cargo test --lib false_positives(pass)bun test src/__test__/document-scaffold-fp.test.ts(pass)bun test src/__test__/person-span-boundary.test.ts(pass)bunx changeset statusshows patch for@stll/anonymizeFollow-ups not fixed
datové schránky:(nominativedatová schránka:works); adding declined triggers rewrites many assemble fixtures (architecture gate).město/městaorg trigger still captures declined city prose (Louny je jako …).Článek 6 Místo plnění.de.stnrregex accepts bare 10-digit application numbers under--countries CZ.Mgr. etbeforeBc. …person spans.Privacy
No contract body, attachment, or full entity dump was committed. Only short public scaffolding snippets appear in tests.
CC on behalf of jan-kubica
@coderabbitai review