Add getAsyncStackTrace API for a shorter async stacktrace#602
Draft
nitely wants to merge 3 commits into
Draft
Conversation
Author
|
Issues:
The tests pass in linux-i386 because the libbacktrace test is skipped. |
getAsyncStackTrace API for a shorter async stacktrace
arnetheduck
reviewed
Jun 17, 2026
| return true | ||
| false | ||
|
|
||
| proc getAsyncStackTrace*(ex: ref Exception): string = |
Member
There was a problem hiding this comment.
hm, what's the use case (outside of tests) for having this public? ie longer term, it feels like we should be working towards an abstract stack trace and not a string
Author
There was a problem hiding this comment.
API parity with getStackTrace. As a end-user you usually want a string. This could be implemented as $getAsyncStackTraceEntries(ex) or something else, though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of nim-lang/Nim#24563
Only differences:
getAsyncStackTraceIt still injects the stack trace into the error msg, but at least that's behind a flag in Chronos, not sure in what case it's needed.