Repository navigation
[2.3.1] Update to stash-native 2.3.1 - #32
Merged
Merged
Conversation
Embed StashNative-2.3.1.aar and xcframework; bump package version and docs. Expose new SetInspectableWebViewsEnabled / IsInspectableWebViewsEnabled in the Unity API (C# + iOS/Android bridges).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases gg.stash.unity 2.3.1 with embedded Stash Native 2.3.1 (Android AAR + iOS
StashNative.xcframework).Changes
StashNative-2.3.0.aar→StashNative-2.3.1.aar(Unity.metaGUID preserved via rename); xcframework device + simulator slices replaced in place (identical file layout, no.metachurn). Both binaries verified to report2.3.1internally.StashNative.SetInspectableWebViewsEnabled(bool)+IsInspectableWebViewsEnabled— opt-in QA/debug flag making checkout WebViews inspectable (Safari Web Inspector on iOS 16.4+,chrome://inspecton Android). Off by default; documented as not for production. Wired through both bridges (StashNativeCardBridge.mm,StashNativeCardUnityBridge.java) to the new static native API. The.mmbridge compiles clean against the embedded 2.3.1 headers.package.json2.3.0 → 2.3.1, README embedded-version line + API reference table, full CHANGELOG entry covering the upstream 2.3.1 changes (external-browser new-window navigation, sub-frame deeplinks, Google Pay redirect code removal, dark-mode/height-clamp/locale fixes).Native-only behavior changes ship inside the binaries and need no wrapper changes; see the native release notes for details.
The Unity sample intentionally does not enable webview inspection (unlike the native sample apps) since it's copy-paste reference code.
Note
Medium Risk
Upgrades embedded payment/checkout native SDKs and changes in-WebView navigation and deeplink handling; the inspectable WebView flag is a security concern if enabled in production builds.
Overview
Releases gg.stash.unity 2.3.1 by bumping the embedded Stash Native 2.3.1 Android AAR and iOS
StashNative.xcframework, withpackage.json, README, and CHANGELOG updated to match.The only new Unity-facing API is
StashNative.SetInspectableWebViewsEnabled(bool)andIsInspectableWebViewsEnabled, an opt-in QA/debug switch (off by default) to make checkout WebViews inspectable via Safari Web Inspector orchrome://inspect. It is plumbed throughStashNativeCardUnityBridge.java,StashNativeCardBridge.mm, andStashNative.cs; callers must enable it before opening checkout and should not ship it enabled in production.Checkout behavior changes from native 2.3.1 (new-window links opening externally, sub-frame deeplinks, removal of Android Google Pay redirect handling, dark-mode WebView and card height/inset fixes) ship inside the binaries with no other wrapper changes.
Reviewed by Cursor Bugbot for commit 5d4b1c8. Bugbot is set up for automated code reviews on this repo. Configure here.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.