Repository navigation
[10/16] Desktop: editor simulator on the desktop host, editor-only natives removed - #29
Draft
richardelms-stash wants to merge 1 commit into
Draft
richardelms-stash wants to merge 1 commit into
richardelms-stash wants to merge 1 commit into
Conversation
richardelms-stash
force-pushed
the
desktop/02-editmode-tests
branch
from
August 26, 2026 10:39
ed4f93b to
5666945
Compare
richardelms-stash
force-pushed
the
desktop/03-editor-rewire
branch
from
August 26, 2026 10:39
a4815bd to
3249d33
Compare
richardelms-stash
force-pushed
the
desktop/02-editmode-tests
branch
from
August 26, 2026 10:57
5666945 to
af1f375
Compare
richardelms-stash
force-pushed
the
desktop/03-editor-rewire
branch
from
August 26, 2026 10:57
3249d33 to
3dd7cf3
Compare
richardelms-stash
force-pushed
the
desktop/02-editmode-tests
branch
from
August 26, 2026 10:58
af1f375 to
72da1a2
Compare
richardelms-stash
force-pushed
the
desktop/03-editor-rewire
branch
from
August 26, 2026 10:58
3dd7cf3 to
0912e39
Compare
richardelms-stash
force-pushed
the
desktop/02-editmode-tests
branch
from
August 26, 2026 10:58
72da1a2 to
b991bb4
Compare
richardelms-stash
force-pushed
the
desktop/03-editor-rewire
branch
from
August 26, 2026 10:58
0912e39 to
8ab622d
Compare
…-only natives The Window/Stash test window now presents the checkout through the stash-native desktop host in window mode at the selected device preset and routes its events into StashNative, so per-call callbacks and global events fire in the editor as on a device; the card config is no longer dropped on the way in. The Simulate buttons stay. Play mode with a Standalone build target opens the desktop host directly with the desktop sizing; mobile targets keep the phone-preset simulator. Editor/Windows (WebView2 launcher DLL) and Editor/macOS (WKWebView launcher bundle, arm64 only) are removed: one webview codebase per OS, a universal mac binary and sound threading. The Stash.Editor.*. WebViewLauncher types are gone (called out in the CHANGELOG).
richardelms-stash
force-pushed
the
desktop/03-editor-rewire
branch
from
August 26, 2026 11:16
8ab622d to
d1f82b1
Compare
richardelms-stash
changed the title
Author
|
/ripley review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
stash-unity stack PR 3 of 5 (targets
desktop/02-editmode-tests, #28). Linear: LAU-299What
Editor/StashEditorPluginWindow.cs: the simulator presents the checkout through the stash-native desktop host in window mode (presentation: "window",width/heightfrom the device presets, new "Desktop card (480x720)" preset) and lets the play-modeStashNativeinstance drain the native events, so per-call callbacks and global events fire exactly as on a device. The reflection contract withStashNative.OpenEditorTestWindownow carries the card / modal config (it was dropped before). Simulate Callbacks buttons and the dismiss-on-close path stay.Runtime/StashNative.cs: in play mode with a Standalone build target the desktop host opens directly in window mode with the desktop sizing (what ships is what is tested); mobile targets keep the phone-preset simulator; the desktop event drain also runs in the editor.Editor/Windows/andEditor/macOS/deleted (WebView2 launcher DLL and the arm64-only WKWebView launcher bundle with itsEditorApplication.delayCall-off-thread callback path). The publicStash.Editor.Windows.WebViewLauncher/Stash.Editor.macOS.WebViewLaunchereditor types go away; the CHANGELOG entry in PR 5 calls this out.Verified
dotnet format whitespace --verify-no-changesclean.OnDialogDismissed.🤖 Generated with Claude Code
https://claude.ai/code/session_01FuG7FjNCGRKxPchjZ8AuUV
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.