Skip to content

fix: Fixes incorrect rendering of some special characters on Super PD… #3024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
antsgar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Fixes incorrect rendering of some special characters on Super PD… #3024

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion packages/web/src/javascripts/Components/SuperEditor/Lexical/Utils/PDFExport/FontConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,13 @@ import { LexicalNode } from 'lexical'
// @ts-expect-error No typing for this package
import { unicodeScripts } from 'unicode-script'

const SYMBOLS_FONT_CHARACTERS_PATTERN =
/[\u2160-\u218F\u2190-\u21FF\u2300-\u23FF\u2460-\u24FF\u2600-\u26FF\u2700-\u27BF]/

const textNeedsSymbolsFont = (text: string): boolean => {
return SYMBOLS_FONT_CHARACTERS_PATTERN.test(text)
}

enum UnicodeScript {
Latin = 'Latin',
Common = 'Common',
Expand Down Expand Up @@ -59,6 +66,7 @@ export enum FontFamily {
NotoSansSC = 'Noto Sans SC',
NotoSansJP = 'Noto Sans JP',
NotoSansKR = 'Noto Sans KR',
NotoSansSymbols = 'Noto Sans Symbols',
Courier = 'Courier',
Helvetica = 'Helvetica',
}
Expand Down Expand Up @@ -174,6 +182,9 @@ const FONT_FAMILY_TO_FONT_SOURCES: Partial<Record<FontFamily, Partial<Record<Fon
[FontFamily.NotoSansKR]: {
[FontVariant.Normal]: '/noto-sans-kr/NotoSansKR-Regular.ttf',
},
[FontFamily.NotoSansSymbols]: {
[FontVariant.Normal]: '/noto-sans-symbols/NotoSansSymbols-VariableFont_wght.ttf',
},
}

export const getFontFamilyForUnicodeScript = (script: UnicodeScript): FontFamily => {
Expand Down Expand Up @@ -270,14 +281,20 @@ const getFontRegisterOptions = (fontFamily: FontFamily) => {
}

export const getFontFamiliesFromLexicalNode = (node: LexicalNode) => {
const scripts: UnicodeScript[] = Array.from(unicodeScripts(node.getTextContent()))
const text = node.getTextContent()
const scripts: UnicodeScript[] = Array.from(unicodeScripts(text))
const fontFamilies = [FontFamily.NotoSans]
scripts.forEach((script) => {
const fontFamilyForScript = getFontFamilyForUnicodeScript(script)
if (!fontFamilies.includes(fontFamilyForScript)) {
fontFamilies.unshift(fontFamilyForScript)
}
})

if (textNeedsSymbolsFont(text)) {
fontFamilies.unshift(FontFamily.NotoSansSymbols)
}

const fontFamiliesSet = new Set(fontFamilies)
return Array.from(fontFamiliesSet)
}
Expand Down
Loading