refactor(app): remove the vestigial RabbitMQ adapter and dead code

[ariostas]

🤖 AI text below 🤖

Removes the vestigial RabbitMQ adaptor from the Flask app and clears out a batch of dead code, duplicated logic and legacy API calls that the repo review turned up. No behavior change is intended beyond two noted cases: the "ServiceX Reports" admin index is now access controlled, and the CLI user create command no longer swallows database errors. A few signatures that were already being edited also picked up PEP 604 unions (M5); there was no repo-wide sweep for that, so it does not get a commit of its own.

How to review. Each finding is one commit; the Commits tab shows them in severity order. Each entry below links to its commit; tick approve or reject under it. To ask for a change instead, leave a review comment on the commit. Rejected commits will be dropped from the branch and this list will be updated to match.

• S1 · simplification · 2e57dd0 · Delete rabbit_adaptor.py and the rabbitmq_adaptor plumbing through create_app, add_routes and make_api, plus the pika dependency; nothing published to or consumed from those exchanges and queues, and real transform work flows through Celery, which keeps RABBIT_MQ_URL as its broker.
  • approve
  • reject
• S4 · simplification · 53202e2 · Drop the uncalled create_tables(), the unreachable return super().format(record), the sys.path.append("/opt/servicex/celery") for a directory the app pod does not mount, and the lambda wrapper in _override_config_with_environ; in decorators.py drop the no-op assert "NoAuthorizationError" and collapse except (NoAuthorizationError, Exception).
  • approve
  • reject
• S5 · simplification · 53f0d6a · Remove the try/except NoResultFound wrappers around .all() queries, which cannot fire, make Dataset.get_by_did_finder and Dataset.get_all return .all() in every branch so they match their list annotations, drop a commented-out lookup, and remove the Flask-SQLAlchemy < 3 fallback in migrations/env.py.
  • approve
  • reject
• S6 · simplification · 3e7121d · Drop the is_complete rejection in add_files_to_processing_queue, which duplicated the live check in LookupResultProcessor off a stale JSON snapshot, unify advertised_endpoint() with ServiceXResource._generate_advertised_endpoint, and move task routing from a celeryd_after_setup hook to task_routes in celeryconfig.py.
  • approve
  • reject
• S7 · simplification · ee5ea9d · Remove the redundant second isinstance(view, ReportView) check and give the "ServiceX Reports" admin a secured index view mirroring the main admin; in the results resource use the to_json_list classmethod instead of calling to_json on an instance and drop an unreachable request_id branch.
  • approve
  • reject
• M2 · modernization · 8d8d38c · Replace distutils.util.strtobool, removed from the standard library in Python 3.12, with a small private helper accepting the same true and false spellings case insensitively.
  • approve
  • reject
• M4 · modernization · d46cda5 · Dataset.find_by_id uses db.session.get(cls, id) instead of the legacy cls.query.get(id), matching UserModel.find_by_id and silencing the LegacyAPIWarning.
  • approve
  • reject
• cli · chore · 9da66f2 · Inline check_user_exists, a one-line alias for UserModel.find_by_sub; add_user rolls back and re-raises instead of printing the exception and reporting success; list_users builds one query instead of fetching every user and then running a second filtered query.
  • approve
  • reject
• tooling · chore · cd942b4 · Delete servicex_app/.pre-commit-config.yaml, which pinned flake8 3.8.4 from a gitlab URL that can no longer be cloned and so broke a repo-wide pre-commit run -a. The root config is the one CI uses.
  • approve
  • reject

Skipped

• S7 resources/datasets/get_all.py: the "show-deleted" in args check always being true was left alone to avoid colliding with other in-flight work on the resource handlers.
• S2, S3, S13 and the rest of transformer_manager.py are out of this PR's scope. cancel_consumer in transformer_manager.py is a Celery control call, not part of the removed adaptor, so it was left alone.

Follow-ups noticed, out of scope

• servicex_app/.flake8 excludes three files that no longer exist: validate_requests.py, find_m.py, messaging.py.
• servicex_app/pyproject.toml still lists pre-commit = "^2.20.0" in the dev group.

Part of #1539.