add datasets page to dashboard - #1532
Open
MattShirley wants to merge 7 commits into
Open
MattShirley wants to merge 7 commits into
MattShirley wants to merge 7 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1532 +/- ##
===========================================
+ Coverage 89.48% 89.72% +0.23%
===========================================
Files 106 108 +2
Lines 3833 3903 +70
Branches 470 483 +13
===========================================
+ Hits 3430 3502 +72
+ Misses 326 324 -2
Partials 77 77 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
for more information, see https://pre-commit.ci
…sl-hep/ServiceX into 1526-add-datasets-to-dashboard
for more information, see https://pre-commit.ci
MattShirley
marked this pull request as ready for review
August 13, 2026 18:33
ponyisi
reviewed
Sep 17, 2026
| def backfill_dataset_stats(session: Session, info: dict): | ||
| if info.get("status") != "success": | ||
| return | ||
| events = info.get("total-events") or 0 |
Collaborator
There was a problem hiding this comment.
so unfortunately total-events does not have a consistent meaning across codegens; for uproot-raw it actually is the number of events passing the filter. I'm honestly a bit uncomfortable with doing this kind of patching...
Contributor
There was a problem hiding this comment.
We agree that @MattShirley will back out the backfill and just deploy the dashboard
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a datasets page to the nav bar.
To improve our reporting of a dataset/files event count and file size:
TransformerFileComplete.backfill_dataset_statsto catch info when the DID finder didn't run (user supplied file lists).AODStatsto catch total event counts when available in logs.