Skip to content

swap transformer resource type from deployment to job - #1514

Draft
MattShirley wants to merge 16 commits into
developfrom
1504-change-transformer-k8s-resource-type-from-deployment-to-job
Draft

MattShirley wants to merge 16 commits into
developfrom
1504-change-transformer-k8s-resource-type-from-deployment-to-job

Conversation

@MattShirley

@MattShirley MattShirley commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Change transformations from deployment to jobs. A shutdown watchdog is added to identify when 1. a DID finder has finished lookup and 2. no files are in the queue for processing. When these are both satisfied, the job pods will shutdown.

This is currently available on testing-1.

@MattShirley MattShirley linked an issue Jul 28, 2026 that may be closed by this pull request
@codecov

codecov Bot commented Jul 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 88.82682% with 20 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.52%. Comparing base (c3c5b5e) to head (897de96).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
servicex_app/servicex_app/transformer_manager.py 84.31% 6 Missing and 2 partials ⚠️
...mer_sidecar/src/transformer_sidecar/transformer.py 44.44% 4 Missing and 1 partial ⚠️
...decar/src/transformer_sidecar/shutdown_watchdog.py 95.18% 4 Missing ⚠️
...ervicex_app/resources/internal/fileset_complete.py 70.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1514      +/-   ##
===========================================
+ Coverage    89.48%   89.52%   +0.04%     
===========================================
  Files          106      107       +1     
  Lines         3833     3935     +102     
  Branches       470      485      +15     
===========================================
+ Hits          3430     3523      +93     
- Misses         326      330       +4     
- Partials        77       82       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MattShirley MattShirley changed the title swap deployment resource type for job swap transformer resource type from deployment to job Jul 28, 2026
@MattShirley
MattShirley marked this pull request as ready for review September 2, 2026 21:58
@MattShirley
MattShirley requested review from BenGalewsky and ponyisi and removed request for BenGalewsky and ponyisi September 2, 2026 21:58
@MattShirley
MattShirley marked this pull request as draft September 3, 2026 15:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change transformer k8s resource type from deployment to job

1 participant