Add new --filter-negative-so2 flag - #836
Merged
Merged
Conversation
…ror-flag The new flag is on by default, error flag flag is still off by default.
|
coverage: 83.605% (+0.003%) from 83.602% — djhoese:feat-omps-so2-neg-filter into ssec:main |
Member
Author
|
The Satpy PR isn't merged yet, but I have some other maintenance I want to do on this project so I'm going to merge this as it has some changes I want. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also rename
--filter-o3flag to--filter-by-error-flag.The new flag is on by default, error flag flag is still off by default.
Should close #820 but we could also wait for @kathys to have time to test it more thoroughly. This PR depends on pytroll/satpy#3455 being merged first for the new keyword argument to be available.