Repository navigation
Conversation
libsmoldyn crate: - Sim owns the simptr (freed on drop, not Clone/Sync), replacing MutSimptr/ConstSimptr whose Clone + Drop double-freed. - SmolError built from smolGetError; notify/warning codes are cleared so they don't stick to later calls. - Bind all of libsmoldyn.h via the cxx bridge, with ErrorCode, MolecState, PanelShape, PanelFace, SrfAction, DrawMode, CmptLogic and RevParam as extern enums checked against the C++ definitions. - Methods split by area under sim/: output, molecules, surfaces, compartments, reactions, ports, lattices, graphics. - include/smolrs.h: read-only simstruct accessors (time, dim, bounds, species) so Rust never depends on the struct layout. - run_with(stop, on_step) steps with a stop flag; run() uses smolRunSimUntil so it isn't cut short after step(). - build.rs reruns cmake when the C/C++ sources change. libsmoldyn.cpp fixes: - smolAddLattice dereferenced sim->latticess before it was allocated. - smolRunCommand left cmd->cmds NULL, so output commands (molcount) segfaulted. smoldyn CLI: first Ctrl-C stops after the current time step (output files flushed), second exits immediately; both exit with 130.
Collaborator
Author
|
Opened here by mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.